Skip to content

Batch Normalization normalizes_to_zero() bug fix #1029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ycscaly
Copy link
Contributor

@ycscaly ycscaly commented Feb 7, 2024

This PR fixes a bug in batch normalization, where non-normalized identity points would be misidentified, and therefore batch normalization would panic in unwraping a None batch inversion result.

See thread in #943 (comment).

@tarcieri

@tarcieri tarcieri merged commit c2d5947 into RustCrypto:master Feb 7, 2024
@ycscaly
Copy link
Contributor Author

ycscaly commented Feb 7, 2024

Can we do a minor release to fix this?

@tarcieri
Copy link
Member

tarcieri commented Feb 7, 2024

@ycscaly I’ll have to backport it, but sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants