Feature/add sm2 pke tests #1172
Closed
+210
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new test file dsa_extended.rs with comprehensive tests for SM2 DSA: - Test different message lengths - Test signature tampering detection - Test special message cases - Add property-based tests for signature consistency
tarcieri
reviewed
May 2, 2025
| let cipher2 = ek.encrypt(&mut rand_core::OsRng, &plaintext1).unwrap(); | ||
|
|
||
| // Different ciphertexts for same plaintext (due to randomness) | ||
| prop_assert_ne!(cipher1, cipher2); |
There was a problem hiding this comment.
Looks like you need to borrow here:
Suggested change
| prop_assert_ne!(cipher1, cipher2); | |
| prop_assert_ne!(&cipher1, &cipher2); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add comprehensive test suite for SM2 PKE (Public Key Encryption) implementation.
Changes
Added new test file
pke_extended.rswith the following test cases:Testing
All tests pass successfully. The new tests provide better coverage for:
Related Issues
N/A
Checklist