Skip to content

const-oid: encoding round trip failure #1752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tarcieri opened this issue Apr 8, 2025 · 1 comment · Fixed by #1753
Closed

const-oid: encoding round trip failure #1752

tarcieri opened this issue Apr 8, 2025 · 1 comment · Fixed by #1753

Comments

@tarcieri
Copy link
Member

tarcieri commented Apr 8, 2025

Caught by proptest:

https://github.com/RustCrypto/formats/actions/runs/14329602501/job/40162382341

proptest: If this test was run on a CI system, you may wish to add the following line to your copy of the file.
cc 61bdeaa6cfc6707a0c4f3e9c6165d99d28042e78acb29b0ca7f747c169e83e74

thread 'round_trip' panicked at const-oid/tests/proptests.rs:31:1:
Test failed: assertion failed: `(left == right)` 
  left: `"1.1.1.270000000"`,
 right: `"1.1.1.1564544"` at const-oid/tests/proptests.rs:40.
minimal failing input: s = "1.1.1.270000000"
	successes: 224
@tarcieri
Copy link
Member Author

tarcieri commented Apr 8, 2025

Now that const_mut_refs is stable and const-oid is MSRV 1.85, it's probably time to rewrite the encoder using mut refs, which should provide many opportunities for simplification

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant