Skip to content

const-oid: fix encoder for 1.1.1.270000000 #1753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 8, 2025
Merged

const-oid: fix encoder for 1.1.1.270000000 #1753

merged 4 commits into from
Apr 8, 2025
+5 −4

Conversation

dishmaker
Copy link
Contributor

@dishmaker dishmaker commented Apr 8, 2025 •
edited
Loading

Fixes #1752

@tarcieri
Copy link
Member

tarcieri commented Apr 8, 2025

@dishmaker you don't need to add a separate test for this. Just add the following line to tests/proptests.proptest-regressions:

cc 61bdeaa6cfc6707a0c4f3e9c6165d99d28042e78acb29b0ca7f747c169e83e74 # shrinks to s = "1.1.1.270000000"

note: I've already done this locally, and plan on working on rewriting/simplifying the encoder using const_mut_refs

@dishmaker dishmaker changed the title const-oid: add test 1.1.1.270000000 const-oid: fix encoder for 1.1.1.270000000 Apr 8, 2025
@tarcieri
Copy link
Member

tarcieri commented Apr 8, 2025

Nice you found the bug

@tarcieri tarcieri merged commit d3e8f9b into RustCrypto:master Apr 8, 2025
114 checks passed
@tarcieri tarcieri mentioned this pull request Apr 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

const-oid: encoding round trip failure
2 participants
@dishmaker @tarcieri