reunite the workspace #1689
Merged
reunite the workspace #1689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baloo
force-pushed
the
baloo/reunite-workspace
branch
from
dfbc0b2 to
a722417
Compare
baloo
force-pushed
the
baloo/reunite-workspace
branch
2 times, most recently
from
251ef95 to
030e87a
Compare
baloo
force-pushed
the
baloo/reunite-workspace
branch
3 times, most recently
from
2142d78 to
9ae40f1
Compare
|
There is something going on in the pem serialization, need to track that down. (#1711) |
baloo
force-pushed
the
baloo/reunite-workspace
branch
2 times, most recently
from
6ac093b to
8ed3739
Compare
baloo
force-pushed
the
baloo/reunite-workspace
branch
from
8ed3739 to
9f63539
Compare
|
@baloo what are the blockers here? I worry about continuing to merge changes to cc @dishmaker |
|
I'd need to rebase and put some time to be sure, but at that point I believe we only miss AEAD: If I could get a merge there that would be great! |
baloo
force-pushed
the
baloo/reunite-workspace
branch
from
9f63539 to
60927ce
Compare
|
actually this will also require RustCrypto/RSA#504 |
baloo
force-pushed
the
baloo/reunite-workspace
branch
2 times, most recently
from
6db0566 to
fb3a50e
Compare
baloo
force-pushed
the
baloo/reunite-workspace
branch
4 times, most recently
from
76456e2 to
b3353e6
Compare
baloo
force-pushed
the
baloo/reunite-workspace
branch
2 times, most recently
from
b473244 to
abb6ca0
Compare
baloo
force-pushed
the
baloo/reunite-workspace
branch
2 times, most recently
from
136c62f to
9f82e17
Compare
baloo
force-pushed
the
baloo/reunite-workspace
branch
from
9f82e17 to
d5dd1bd
Compare
|
@baloo can you mark this as ready if you think it's past the draft stage? |
|
I need to move the git pin from my PR branch and then I can do that. I’ll do that when I get back home (2-3h) |
baloo
force-pushed
the
baloo/reunite-workspace
branch
from
d5dd1bd to
7d9c8b8
Compare
tarcieri
approved these changes
Apr 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
workspace got split in #1670, this bring back the crates left outside back in the workspace.
Depends: