Skip to content

gss-api: change NegHints::hint_name to GeneralStringRef type #1779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 25, 2025
Merged

gss-api: change NegHints::hint_name to GeneralStringRef type #1779

merged 7 commits into from
Apr 25, 2025

Conversation

dishmaker
Copy link
Contributor

Better than using AnyRef and .value()[2..]

@dishmaker dishmaker mentioned this pull request Apr 22, 2025
Merged
baloo
baloo reviewed Apr 22, 2025
View reviewed changes
@dishmaker @baloo
remove TODO
c7dc16e 
Co-authored-by: Arthur Gautier <[email protected]>
@tarcieri
Copy link
Member

If you made this type opaque instead of exposing its contents, we could probably add something like GeneralStringRef directly to der, even if it provided little or no functionality (at least to start with)

@tarcieri tarcieri merged commit 8364eb5 into RustCrypto:master Apr 25, 2025
107 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baloo baloo baloo left review comments

@tarcieri tarcieri tarcieri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dishmaker @tarcieri @baloo