-
Notifications
You must be signed in to change notification settings - Fork 91
argon2: detect allocation failures in hash_password_into
#568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that my allocation-only benchmark in #566 suggests this could be a tiny bit slower than vec![Block::default, ...]
.
So maybe it would be good to benchmark this with high-ish memory sizes, or at least with the 19 MiB and 46 MiB sizes recommended by OWASP?
Maybe we should try to land #547 first so we can gauge any impact on performance? |
I think we should merge this PR, then #547 without the alignment workaround after it was migrated to |
Closes #566