dsa: capture error #941
Merged
dsa: capture error #941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baloo
force-pushed
the
baloo/dsa/capture-error
branch
2 times, most recently
from
149d490 to
895e437
Compare
baloo
force-pushed
the
baloo/dsa/capture-error
branch
from
895e437 to
40003e0
Compare
baloo
force-pushed
the
baloo/dsa/capture-error
branch
from
40003e0 to
5f7c6ad
Compare
baloo
commented
Apr 23, 2025
ecdsa/src/der.rs
Outdated
| assert!( | ||
| Signature::from_der(&[ | ||
| der::Tag::Sequence.into(), | ||
| der::Tag::Sequence.number().value().try_into().unwrap(), |
There was a problem hiding this comment.
Not exactly a fan.
Maybe we should have a impl TryFrom<der::Tag> for u8 or something.
There was a problem hiding this comment.
and we lose the constructed bit.
There was a problem hiding this comment.
There used to be a From impl, but I guess it was removed when tags were changed to support longer than 1-byte lengths
There was a problem hiding this comment.
Yeah, and we lost the Constructed bit at this moment so you have to rebuild it manually. I don't know.
I think I'm fine with just hardcoding the value here with a comment.
There was a problem hiding this comment.
The old From impl and a hypothetical TryFrom impl should preserve the constructed bit, but hardcoding it seems fine for now
baloo
force-pushed
the
baloo/dsa/capture-error
branch
from
5f7c6ad to
c5854a9
Compare
tarcieri
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.