ecdsa: use blanket impl from signature 3
#945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baloo
force-pushed
the
baloo/signature/blanket-impl
branch
2 times, most recently
from
326d663 to
fa55b79
Compare
baloo
force-pushed
the
baloo/signature/blanket-impl
branch
2 times, most recently
from
7b989c1 to
1a6f687
Compare
baloo
force-pushed
the
baloo/signature/blanket-impl
branch
from
1a6f687 to
f9c773e
Compare
tarcieri
reviewed
Apr 23, 2025
tarcieri
reviewed
Apr 23, 2025
ecdsa/CHANGELOG.md
Outdated
Comment on lines
9
to
10
| ### Changed | ||
| - `DigestPrimitive` was removed from hazmat ([#945]) |
There was a problem hiding this comment.
Perhaps put the removal under ### Removed
There was a problem hiding this comment.
Well, it was not removed per se. I changed the wording of the line instead.
tarcieri
approved these changes
Apr 23, 2025
baloo
force-pushed
the
baloo/signature/blanket-impl
branch
from
0d49221 to
774419c
Compare
This was referenced Apr 23, 2025
baloo
added a commit
to baloo/signatures
that referenced
this pull request
May 4, 2025
This reverts commit 8e6bb26.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is stacked on #944
This makes use of RustCrypto/traits#1827