crypto-common: use core::error::Error trait; MSRV 1.81
#1660
Conversation
The `core::error::Error` trait is now stable, meaning we no longer need to gate impls for it on a `std` feature.
|
Note: only did |
|
Also, perhaps we should consider removing the Right now std = ["getrandom?/std", "rand_core?/std"]I didn't remove it to keep the change minimal for now, but it's something we could do potentially. I don't think the transitive activation of the |
|
I would really like to migrate to
I agree. |
|
Okay, will leave this as-is and we can take a look again when 1.82 is released (October 17th) |
|
If this is merged, will you make similar changes to crates in other repositories owned by RustCrypto? |
|
Yes, we will apply similar changes (including MSRV bump) to our downstream crates as well. Since RustCrypto/hybrid-array#85 has already landed, we are likely to move forward with this change. |
tarcieri
changed the title
core::error::Error trait; MSRV 1.81core::error::Error trait; MSRV 1.81
|
I removed draft. I'll hold off on merging until I'm ready to update the downstream crates accordingly (busy today / this weekend) |
The MSRVs for dependent crates did not get bumped before #1660 was merged. This bumps them accordingly.
The MSRVs for dependent crates did not get bumped before #1660 was merged. This bumps them accordingly.
The MSRVs for dependent crates did not get bumped before #1660 was merged. This bumps them accordingly.
The MSRVs for dependent crates did not get bumped before #1660 was merged. This bumps them accordingly.
The MSRVs for dependent crates did not get bumped before #1660 was merged. This bumps them accordingly.
The MSRVs for dependent crates did not get bumped before #1660 was merged. This bumps them accordingly.
The MSRVs for dependent crates did not get bumped before #1660 was merged. This bumps them accordingly.
As of #1660, the `crypto-common` crate stopped linking `std` entirely by switching to `core::error::Error`. That PR didn't remove the `std` feature however, which was retained to transitively activate the `std` features of `getrandom` and `rand_core` optioinally in the event their corresponding features are enabled. This PR goes ahead and removes it entirely, which also unblocks being able to remove the `std` feature from other crates like `aead`, `cipher`, `digest`, and `universal-hash`.
As of #1660, the `crypto-common` crate stopped linking `std` entirely by switching to `core::error::Error`. That PR didn't remove the `std` feature however, which was retained to transitively activate the `std` features of `getrandom` and `rand_core` optioinally in the event their corresponding features are enabled. This PR goes ahead and removes it entirely, which also unblocks being able to remove the `std` feature from other crates like `aead`, `cipher`, `digest`, and `universal-hash`.
As of #1660, the `crypto-common` crate stopped linking `std` entirely by switching to `core::error::Error`. That PR didn't remove the `std` feature however, which was retained to transitively activate the `std` features of `getrandom` and `rand_core` optioinally in the event their corresponding features are enabled. This PR goes ahead and removes it entirely, which also unblocks being able to remove the `std` feature from other crates like `aead`, `cipher`, `digest`, and `universal-hash`.
The
core::error::Errortrait is now stable, meaning we no longer need to gate impls for it on astdfeature.