Skip to content

feat: Update to rand_core v0.9.0 #1745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

feat: Update to rand_core v0.9.0 #1745

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
30b1718
feat: Update to rand_core v0.9.0
GeekMasher Feb 9, 2025
19cd820
fix(password-hash): Revert feature cfg and update to RngCore
GeekMasher Feb 9, 2025
09041c7
fix(password-hash): Update to use CryptoRng
GeekMasher Feb 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
96 changes: 63 additions & 33 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions password-hash/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,13 @@ base64ct = "1.6"
subtle = { version = "2", default-features = false }

# optional dependencies
rand_core = { version = "0.6.4", optional = true, default-features = false }
rand_core = { version = "0.9.0", optional = true, default-features = false }

[features]
default = ["rand_core"]
alloc = ["base64ct/alloc"]

getrandom = ["rand_core/getrandom"]
getrandom = ["rand_core/os_rng"]

[package.metadata.docs.rs]
all-features = true
Expand Down
4 changes: 2 additions & 2 deletions password-hash/src/salt.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ use core::{fmt, str};

use crate::errors::InvalidValue;
#[cfg(feature = "rand_core")]
use rand_core::CryptoRngCore;
use rand_core::CryptoRng;

/// Error message used with `expect` for when internal invariants are violated
/// (i.e. the contents of a [`Salt`] should always be valid)
Expand Down Expand Up @@ -203,7 +203,7 @@ pub struct SaltString {
impl SaltString {
/// Generate a random B64-encoded [`SaltString`].
#[cfg(feature = "rand_core")]
pub fn generate(mut rng: impl CryptoRngCore) -> Self {
pub fn generate(mut rng: impl CryptoRng) -> Self {
let mut bytes = [0u8; Salt::RECOMMENDED_LENGTH];
rng.fill_bytes(&mut bytes);
Self::encode_b64(&bytes).expect(INVARIANT_VIOLATED_MSG)
Expand Down