lzma implementation #5717
Open
lzma implementation #5717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This turned out surprisingly effective, about 2/3s of the tests pass, which is enough for me at the moment. The main missing parts involve a bunch of unsafe things that As a side note I also abstracted out |
arihant2math
force-pushed
the
lzma
branch
2 times, most recently
from
c09442c to
2bad5d2
Compare
|
Lots of tests are failing because they were previously blocked due to no implementation at all. |
|
Would you be able to squash these commits down? Ideally into one for copying the files from cpython, and one for all the rest? |
|
Sure |
Signed-off-by: Ashwin Naren <[email protected]>
Signed-off-by: Ashwin Naren <[email protected]>
arihant2math
force-pushed
the
lzma
branch
2 times, most recently
from
22ab4cb to
19a43f5
Compare
Signed-off-by: Ashwin Naren <[email protected]>
|
It's at 3 now, I committed things in a weird fashion so I can't get it below that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #5709 because of the zlib abstraction.