-
Notifications
You must be signed in to change notification settings - Fork 68
[GSMG] Add new object type #593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 11 commits
0370149
74d0731
e9c6fd4
aa1a675
2375a38
588a57f
fe66017
3af26d3
6a0f91d
1dc1a0b
370a0e3
a777188
2898e05
e0b5e18
5bbb486
b7a4c18
1fe7cad
a13a41b
13820b5
4b2edfa
071a0fe
ca1ca16
ec6075d
ce1b698
222c9c8
752ac82
7c34be4
6975501
65de592
4fda525
cd87281
1ec018b
acbd246
5676338
332849b
db43d0c
6f9caec
cb3be75
a54a743
cfc32c5
f939a76
a4778d7
880cba2
7d6f46d
e8a7d73
639368d
c447d3a
328b92b
7c92e51
a1b3e5a
25b0135
7e7859c
4b3fdc5
a3a5de8
ae2976c
cf1e23b
d287a97
125a8fa
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
# GSMG File Format | ||
|
||
File | Cardinality | Definition | Schema | Example | ||
:--- | :--- | :--- | :--- | :--- | ||
`<name>.gsmg.json` | 1 | [`zif_aff_gsmg_v1.intf.abap`](./type/zif_aff_gsmg_v1.intf.abap) | [`gsmg-v1.json`](./gsmg-v1.json) | ||
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
{ | ||
"formatVersion": "1", | ||
"header": { | ||
"description": "For testing", | ||
"originalLanguage": "en", | ||
"abapLanguageVersion": "standard" | ||
}, | ||
"generalInformation": { | ||
"type": "USAGE", | ||
"detailedDescription": "This Metric Group is for testing" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What is this description about? Is it an extension of the description field in the header? So like the name says, is it for describing the object in more detail than the header-description allows? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Exactly right :-) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just some additional questions: Did you thought about extending the standard description to 255 characters. As far as I know, this should be possible. If it is more a documentation. Did you consider to provide documentation using KTD? |
||
} | ||
} | ||
mseich marked this conversation as resolved.
Show resolved
Hide resolved
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,117 @@ | ||
{ | ||
"$comment": "This file is autogenerated, do not edit manually, see https://github.com/SAP/abap-file-formats for more information.", | ||
"$schema": "https://json-schema.org/draft/2020-12/schema", | ||
"$id": "https://github.com/SAP/abap-file-formats/blob/main/file-formats/gsmg/gsmg-v1.json", | ||
"title": "Metric Group", | ||
"description": "Metric Group (GSMG)", | ||
"type": "object", | ||
"properties": { | ||
"formatVersion": { | ||
"title": "ABAP File Format Version", | ||
"description": "The ABAP file format version", | ||
"type": "string", | ||
"const": "1" | ||
}, | ||
"header": { | ||
"title": "Header", | ||
"description": "Header", | ||
"type": "object", | ||
"properties": { | ||
"description": { | ||
"title": "Description", | ||
"description": "Description of the ABAP object", | ||
"type": "string", | ||
"maxLength": 60 | ||
}, | ||
"originalLanguage": { | ||
"title": "Original Language", | ||
"description": "Original language of the ABAP object", | ||
"type": "string", | ||
"minLength": 2, | ||
"maxLength": 2, | ||
"pattern": "^[a-z]+$" | ||
}, | ||
"abapLanguageVersion": { | ||
"title": "ABAP Language Version", | ||
"description": "ABAP language version", | ||
"type": "string", | ||
"enum": [ | ||
"standard", | ||
"cloudDevelopment" | ||
], | ||
"enumTitles": [ | ||
"Standard", | ||
"ABAP Cloud Development" | ||
], | ||
"enumDescriptions": [ | ||
"Standard", | ||
"ABAP cloud development" | ||
], | ||
"default": "standard" | ||
} | ||
}, | ||
"additionalProperties": false, | ||
"required": [ | ||
"description", | ||
"originalLanguage" | ||
] | ||
}, | ||
"generalInformation": { | ||
"title": "General information", | ||
"description": "General information", | ||
"type": "object", | ||
"properties": { | ||
"type": { | ||
"title": "Category", | ||
"description": "Category", | ||
"type": "string", | ||
"enum": [ | ||
"AVAIL", | ||
"PERFORM", | ||
"EXCEPTION", | ||
"CONFIGURE", | ||
"USAGE", | ||
"SELFMON", | ||
"METERING" | ||
], | ||
"enumTitles": [ | ||
"Availability", | ||
"Performance", | ||
"Exceptions", | ||
"Configuration", | ||
"Usage", | ||
"Self Monitoring", | ||
"Metering" | ||
], | ||
"enumDescriptions": [ | ||
"Availability", | ||
"Performance", | ||
"Exceptions", | ||
"Configuration", | ||
"Usage", | ||
"Self Monitoring", | ||
"Metering" | ||
], | ||
"default": "USAGE" | ||
}, | ||
"detailedDescription": { | ||
"title": "Detailed description", | ||
"description": "Detailed description", | ||
"type": "string", | ||
"maxLength": 255 | ||
} | ||
}, | ||
"additionalProperties": false, | ||
"required": [ | ||
"type", | ||
"detailedDescription" | ||
] | ||
} | ||
}, | ||
"additionalProperties": false, | ||
"required": [ | ||
"formatVersion", | ||
"header", | ||
"generalInformation" | ||
] | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,99 @@ | ||
INTERFACE zif_aff_gsmg_v1 | ||
PUBLIC. | ||
|
||
TYPES: | ||
|
||
"! <p class="shorttext">Category</p> | ||
"! Category | ||
"! $values {@link zif_aff_gsmg_v1.data:co_category} | ||
"! $default {@link zif_aff_gsmg_v1.data:co_category.usage} | ||
ty_category TYPE c LENGTH 10, | ||
|
||
"! <p class="shorttext">Detailed description</p> | ||
"! Detailed description | ||
mseich marked this conversation as resolved.
Show resolved
Hide resolved
|
||
ty_detailed_description TYPE c LENGTH 255, | ||
|
||
|
||
"! <p class="shorttext">General information</p> | ||
"! General information | ||
mseich marked this conversation as resolved.
Show resolved
Hide resolved
|
||
BEGIN OF ty_general_information, | ||
"! <p class="shorttext">Category</p> | ||
"! Category | ||
"! $required | ||
type TYPE ty_category, | ||
mseich marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
"! <p class="shorttext">Detailed description</p> | ||
"! Detailed description | ||
mseich marked this conversation as resolved.
Show resolved
Hide resolved
|
||
"! $required | ||
detailed_description TYPE ty_detailed_description, | ||
|
||
END OF ty_general_information. | ||
|
||
|
||
CONSTANTS: | ||
|
||
"! <p class="shorttext">Category</p> | ||
"! Category | ||
BEGIN OF co_category, | ||
|
||
"! <p class="shorttext">Availability</p> | ||
"! Availability | ||
"! $enumValue 'AVAIL' | ||
mseich marked this conversation as resolved.
Show resolved
Hide resolved
|
||
availability TYPE ty_category VALUE 'AVAIL', | ||
|
||
"! <p class="shorttext">Performance</p> | ||
"! Performance | ||
"! $enumValue 'PERFORM' | ||
performance TYPE ty_category VALUE 'PERFORM', | ||
|
||
"! <p class="shorttext">Exceptions</p> | ||
"! Exceptions | ||
"! $enumValue 'EXCEPTION' | ||
exceptions TYPE ty_category VALUE 'EXCEPTION', | ||
|
||
"! <p class="shorttext">Configuration</p> | ||
"! Configuration | ||
"! $enumValue 'CONFIGURE' | ||
configuration TYPE ty_category VALUE 'CONFIGURE', | ||
|
||
"! <p class="shorttext">Usage</p> | ||
"! Usage | ||
"! $enumValue 'USAGE' | ||
usage TYPE ty_category VALUE 'USAGE', | ||
|
||
"! <p class="shorttext">Self Monitoring</p> | ||
"! Self Monitoring | ||
mseich marked this conversation as resolved.
Show resolved
Hide resolved
|
||
"! $enumValue 'SELFMON' | ||
self_monitoring TYPE ty_category VALUE 'SELFMON', | ||
|
||
"! <p class="shorttext">Metering</p> | ||
"! Metering | ||
"! $enumValue 'METERING' | ||
metering TYPE ty_category VALUE 'METERING', | ||
|
||
END OF co_category. | ||
|
||
|
||
|
||
TYPES: | ||
|
||
"! <p class="shorttext">Metric Group</p> | ||
"! Metric Group (GSMG) | ||
BEGIN OF ty_main, | ||
|
||
"! $required | ||
format_version TYPE zif_aff_types_v1=>ty_format_version, | ||
|
||
"! <p class="shorttext">Header</p> | ||
"! Header | ||
"! $required | ||
header TYPE zif_aff_types_v1=>ty_header_60_cloud, | ||
|
||
"! <p class="shorttext">General information</p> | ||
"! General information | ||
mseich marked this conversation as resolved.
Show resolved
Hide resolved
|
||
"! $required | ||
general_information TYPE ty_general_information, | ||
|
||
END OF ty_main. | ||
|
||
ENDINTERFACE. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{ | ||
"formatVersion": "1", | ||
"header": { | ||
"description": "GSMP AFF Type (Generic Simple Metric Collector)", | ||
"originalLanguage": "en" | ||
} | ||
} |
Uh oh!
There was an error while loading. Please reload this page.