[EDOT] Add new object EDOT #682
Conversation
There was a problem hiding this comment.
Thanks for your pull request. This pull request still contains both, EDOI and EDOT (with the .DS_Store). Please remove all the unwanted files here.
Please note, that for the title and description, we use title case and sentence case respectively. I've not marked every occurrence but if you could please adjust that.
"! <p class="shorttext">Interface Version</p> "<- title (title case)
"! Interface version "<- description (sentence case)
file-formats/edot/README.md
Outdated
There was a problem hiding this comment.
I think having an example would also help me for the review
There was a problem hiding this comment.
Somehow I am unable to generate example, I created class and Transformation but its not clear to me in the report what object to be mentioned as input.
I corrected and pushed the latest changes, can you please check |
There was a problem hiding this comment.
Thank you for submitting the AFF and changes. Most of my comments are minors and just a personal touch, up to you if you want to implement them :)
However, I always like to mention that AFF is a readable representation of an ABAP Object Type, and the more coherent the field names are, the better!
|
|
||
| TYPES: | ||
| "! <p class="shorttext">SRAL Configuration Type</p> | ||
| "! SRAL configuration type |
There was a problem hiding this comment.
what does SRAL stand for? Apologies if I might have missed it
There was a problem hiding this comment.
Hello GuilhermeSaraiva,
Its about Read access logging setup. For more information
https://help.sap.com/doc/863abf53d25ab64ce10000000a174cb4/700_SFIN3E%20006/en-US/b10184538ca0e647e10000000a441470.html
There was a problem hiding this comment.
What do you think is most common Term for the end user? RAL, SRAL or Read Access Logging? We want to avoid that internal terminology is present in AFF. Could you please confirm it with your UA?
GuilhermeSaraiva96
added
ux-review ready
| TYPES: | ||
| "! <p class="shorttext">General Information</p> | ||
| "! General information | ||
| BEGIN OF ty_edoc_information, |
There was a problem hiding this comment.
| BEGIN OF ty_edoc_information, | |
| BEGIN OF ty_general_information, |
| general_information TYPE ty_edoc_information, | ||
| "! <p class="shorttext">Additional Selection Fields</p> | ||
| "! Additional selection fields of validation report | ||
| sral_configuration TYPE ty_sral_configurations, |
There was a problem hiding this comment.
The field name is called sral_configuration, but the title is: Additional Selection Fields. These are not coherent, which would be best for the end user to understand what kind of field this is?
|
|
||
| TYPES: | ||
| "! <p class="shorttext">SRAL Configuration Type</p> | ||
| "! SRAL configuration type |
There was a problem hiding this comment.
What do you think is most common Term for the end user? RAL, SRAL or Read Access Logging? We want to avoid that internal terminology is present in AFF. Could you please confirm it with your UA?
No description provided.