fix: product tabs now display correctly on second click #20166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ragraph-container
…ed readability and performance
… better readability
spartacus
|
||||||||||||||||||||||||||||
| Project |
spartacus
|
| Branch Review |
fix/CXSPA-9586
|
| Run status |
|
| Run duration | 04m 23s |
| Commit |
|
| Committer | Norbert Papp |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
3
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
102
|
| View all changes introduced in this branch ↗︎ | |
rmch91
requested changes
Apr 15, 2025
| @@ -80,7 +81,8 @@ export class TabParagraphContainerComponent implements AfterViewInit, OnInit { | |||
| constructor( | |||
| public componentData: CmsComponentData<CMSTabParagraphContainer>, | |||
| protected cmsService: CmsService, | |||
| protected winRef: WindowRef | |||
| protected winRef: WindowRef, | |||
| protected cdr: ChangeDetectorRef | |||
There was a problem hiding this comment.
major: For DI, let's use the inject function instead of a constructor to avoid introducing unnecessary breaking changes. See: https://wiki.one.int.sap/wiki/display/spar/Coding+Guidelines#CodingGuidelines-Useinject()functioninsteadofconstructorforDependencyInjection
…mproved change detection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CXSPA-9586
Fixed an issue where opening a product second time from home page did not display its tabs.