Skip to content

[INTERNAL] Fix unit/coverage setup on Node 20 and adapt CI matrix #923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2023

Conversation

matz3
Copy link
Member

@matz3 matz3 commented Jul 13, 2023

AVA's nodeArguments option doesn't seem to work with loaders on Node 20.
One solution is to disable worker threads to use child processes instead.

This solution has anyways already been applied via #921
and is now enabled for all test executions.

JIRA: CPOUI5FOUNDATION-612

AVA's nodeArguments option doesn't seem to work with loaders on Node 20.
One solution is to disable worker threads to use child processes instead.

This solution has anyways already been applied via #921
and is now enabled for all test executions.

JIRA: CPOUI5FOUNDATION-612
@coveralls
Copy link

Coverage Status

coverage: 94.603%. remained the same when pulling ca430af on fix-test-setup-node-20 into de2cc12 on main.

@matz3 matz3 requested a review from a team July 13, 2023 15:32
@matz3 matz3 merged commit 61d60d8 into main Jul 14, 2023
@matz3 matz3 deleted the fix-test-setup-node-20 branch July 14, 2023 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants