Skip to content

refactor(ui5-menu): remove references to parent #11217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

refactor(ui5-menu): remove references to parent #11217

wants to merge 8 commits into from

Conversation

didip1000
Copy link
Contributor

@didip1000 didip1000 commented Mar 31, 2025 •
edited
Loading

Refactored submenu closing and navigation handling, removing references to the parent element:

  • MenuItems now close their own submenus when necessary.
  • Exiting end content navigation with the up/down arrow keys with throw an exit-end-content event, which is handled by the parent Menu or MenuItem.
  • Fixed an issue with menu item navigation when holding down space on a menu item with a submenu.

@didip1000 didip1000 self-assigned this Mar 31, 2025
@didip1000 didip1000 requested a review from hinzzx March 31, 2025 07:05
hinzzx
hinzzx requested changes Apr 3, 2025
View reviewed changes
hinzzx
hinzzx reviewed Apr 9, 2025
View reviewed changes
@didip1000 didip1000 requested a review from hinzzx April 9, 2025 16:44
hinzzx
hinzzx reviewed Apr 15, 2025
View reviewed changes
hinzzx
hinzzx reviewed Apr 15, 2025
View reviewed changes
Copy link
Contributor

@hinzzx hinzzx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please re-base to main branch since few WDIO tests are failing, I believe due to old ChromeDriver version.

hinzzx
hinzzx approved these changes Apr 16, 2025
View reviewed changes
Copy link
Contributor

@hinzzx hinzzx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks good from my side

@didip1000 didip1000 marked this pull request as ready for review April 17, 2025 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nnaydenow nnaydenow nnaydenow left review comments

@hinzzx hinzzx hinzzx approved these changes

@tsanislavgatev tsanislavgatev Awaiting requested review from tsanislavgatev

Assignees

@didip1000 didip1000

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@didip1000 @nnaydenow @hinzzx