Skip to content

fix(ui5-button): announce aria description #11264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 23, 2025
Merged

fix(ui5-button): announce aria description #11264

merged 4 commits into from
Apr 23, 2025

Conversation

unazko
Copy link
Contributor

@unazko unazko commented Apr 4, 2025 •
edited
Loading

Issue:

  • The accessibleDescription text is not getting announced by the screen reader when the ui5-button
    has it's design attribute set.

Solution:

  • Move the text related to the design property from the aria-describedby to the aria-description attribute.

Fixes: #10899

@unazko unazko marked this pull request as ready for review April 7, 2025 10:22
@unazko unazko requested a review from hinzzx April 14, 2025 07:16
@unazko unazko merged commit f8e77cb into main Apr 23, 2025
12 checks passed
@unazko unazko mentioned this pull request Apr 23, 2025
Closed
1 task
@ui5-webcomponents-bot
Copy link
Collaborator

🎉 This PR is included in version v2.10.0-rc.2 🎉

The release is available on v2.10.0-rc.2

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nnaydenow nnaydenow nnaydenow approved these changes

@hinzzx hinzzx hinzzx approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[a11y][Button]: Attribute 'accessibleDescription' is not read by screenreader for Negative design
4 participants
@unazko @ui5-webcomponents-bot @nnaydenow @hinzzx