Skip to content

feat(ui5-shellbar): introduce branding slot #11287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

Conversation

yanaminkova
Copy link
Member

The branding slot has been introduced to the ui5-shellbar component.
Additionally, a new component called ui5-shellbar-branding has been added. This component combines a logo and a title, with the ability to open links. Its primary purpose is to be used within the branding slot, replacing the default primary title and logo of the ui5-shellbar.

The branding slot and its content take higher priority. As a result, if both the branding and the primary title + logo slot are used, only the ui5-shellbar-branding will be displayed.

@yanaminkova yanaminkova marked this pull request as draft April 8, 2025 13:47
@ilhan007
Copy link
Member

ilhan007 commented Apr 10, 2025

Rebase with the main, chromedriver has been updated and some failing tests have been fixed

@yanaminkova yanaminkova marked this pull request as ready for review April 14, 2025 08:12
@yanaminkova yanaminkova marked this pull request as draft April 14, 2025 09:14
@yanaminkova yanaminkova marked this pull request as ready for review April 14, 2025 10:27
@yanaminkova yanaminkova deleted the ui5-sb-branding branch April 16, 2025 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants