Skip to content

fix(ui5-page): refactor page layouting #11291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix(ui5-page): refactor page layouting #11291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
095c0db
fix(ui5-page): refactor page layouting
ivoplashkov Apr 9, 2025
e734660
fix(ui5-page): refactor page layouting
ivoplashkov Apr 9, 2025
fb6d721
fix(ui5-page): refactor page layouting
ivoplashkov Apr 9, 2025
15b17f3
fix(ui5-page): refactor page layouting
ivoplashkov Apr 9, 2025
579c5c3
Merge remote-tracking branch 'origin/main' into refactor-page-layout
ivoplashkov Apr 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/fiori/src/Page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ class Page extends UI5Element {
}

get _contentPaddingBottom() {
return !this.fixedFooter && !this.hideFooter ? "3.5rem" : "0";
return !this.fixedFooter && !this.hideFooter ? "3.75rem" : "0";
}

get _contentTop() {
Expand Down
29 changes: 17 additions & 12 deletions packages/fiori/src/themes/Page.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

:host(:not([hidden])) {
width: 100%;
height: 100%;
Expand All @@ -13,6 +12,8 @@
z-index: 0;
box-sizing: border-box;
background-color: inherit;
display: flex;
flex-direction: column;
}

.ui5-page-header-root {
Expand All @@ -21,11 +22,9 @@

.ui5-page-content-root {
overflow: hidden auto;
position: absolute;
will-change: scroll-position;
width: 100%;
top: 2.75rem;
bottom: 0;
flex: 1 1 auto;
box-sizing: border-box;
font-size: var(--sapFontSize);
color: var(--sapTextColor);
Expand All @@ -34,26 +33,27 @@
.ui5-page-footer-root {
width: 100%;
box-sizing: border-box;
position: absolute;
bottom: 0;
left: 0;
z-index: 2;
width: 100%;
}

:host(:not([fixed-footer])) .ui5-page-footer-root {
opacity: 1;
bottom: 0.5rem;
}
/*** Responsive paddings ***/

::slotted([ui5-bar][slot="footer"][design="FloatingFooter"]) {
margin: auto;
padding: 0;
position: absolute;
bottom: 10px;
box-sizing: border-box;
left: 50%;
transform: translateX(-50%);
width: 95%;
z-index: 2;
}

/* S Size */
@container (max-width: 599px) {

:host([floating-footer]) .ui5-page-footer-root,
.ui5-page-content-root {
padding: 0 1rem;
Expand All @@ -72,6 +72,7 @@

/* M Size */
@container (min-width: 600px) and (max-width: 1023px) {

:host([floating-footer]) .ui5-page-footer-root,
.ui5-page-content-root {
padding: 0 2rem;
Expand All @@ -90,6 +91,7 @@

/* L Size */
@container (min-width: 1024px) and (max-width: 1439px) {

:host([floating-footer]) .ui5-page-footer-root,
.ui5-page-content-root {
padding: 0 2rem;
Expand All @@ -108,6 +110,7 @@

/* XL Size */
@container (min-width: 1440px) {

:host([floating-footer]) .ui5-page-footer-root,
.ui5-page-content-root {
padding: 0 3rem;
Expand Down Expand Up @@ -159,6 +162,7 @@
transform: translateY(100%);
opacity: 0;
}

100% {
opacity: 1;
}
Expand All @@ -169,8 +173,9 @@
transform: translateY(-5%);
opacity: 1;
}

100% {
transform: translateY(100%);
opacity: 0;
}
}
}