Skip to content

Aqua + typos CI #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .typos.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
[default.extend-words]
9 changes: 8 additions & 1 deletion Project.toml
Original file line number Diff line number Diff line change
Expand Up @@ -14,20 +14,27 @@ RecursiveArrayTools = "731186ca-8d62-57ce-b412-fbd966d074cd"
StaticArrays = "90137ffa-7385-5640-81b9-e52037218182"

[compat]
Aqua = "0.8"
ArrayInterface = "7"
ChainRulesCore = "1"
ChainRulesTestUtils = "1"
ForwardDiff = "0.10.3"
InteractiveUtils = "1"
LinearAlgebra = "1"
MacroTools = "0.5"
OrdinaryDiffEq = "6"
PreallocationTools = "0.4"
RecursiveArrayTools = "2,3"
StaticArrays = "1.0"
Test = "1"
julia = "1.6"

[extras]
Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
ChainRulesTestUtils = "cdddcdb0-9152-4a09-a978-84456f9df70a"
InteractiveUtils = "b77e0a4c-d291-57a0-90e8-8db25a27a240"
OrdinaryDiffEq = "1dea7af3-3e70-54e6-95c3-0bf5283fa5ed"
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"

[targets]
test = ["Test", "OrdinaryDiffEq", "InteractiveUtils", "ChainRulesTestUtils"]
test = ["Aqua", "Test", "OrdinaryDiffEq", "InteractiveUtils", "ChainRulesTestUtils"]
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ julia> SLArray{Tuple{2, 2}}(a = 1, b = 2, c = 3, d = 4)

Constructing copies with some items changed is supported by
a keyword constructor whose first argument is the source and
additonal keyword arguments change several entries.
additional keyword arguments change several entries.

```julia
julia> v1 = SLVector(a = 1.1, b = 2.2, c = 3.3);
Expand Down
4 changes: 1 addition & 3 deletions src/LabelledArrays.jl
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,6 @@ end

export SLArray, LArray, SLVector, LVector, @SLVector, @LArray, @LVector, @SLArray

export @SLSliced, @LSliced

export symbols, dimSymbols, rowSymbols, colSymbols
export symbols

end # module
6 changes: 3 additions & 3 deletions src/larray.jl
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ macro LVector(type, syms)
end
end

#the following gives errror: TypeError: in <:, expected Type, got TypeVar
#the following gives error: TypeError: in <:, expected Type, got TypeVar
#symbols(::LArray{T,N,D<:AbstractArray{T,N},Syms}) where {T,N,D,Syms} = Syms

"""
Expand Down Expand Up @@ -367,8 +367,8 @@ For example:
B = ABCD(1,2,3,4);
B2 = SLArray(B; c=30 )
"""
function SLArray(v1::Union{SLArray{S, T, N, L, Syms}, LArray{T, N, D, Syms}};
kwargs...) where {S, T, N, L, Syms, D}
function SLArray(v1::SLArray{S, T, N, L, Syms};
kwargs...) where {S, T, N, L, Syms}
t2 = merge(convert(NamedTuple, v1), values(kwargs))
SLArray{S}(t2)
end
Expand Down
12 changes: 12 additions & 0 deletions test/qa.jl
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
using LabelledArrays, Aqua
@testset "Aqua" begin
Aqua.find_persistent_tasks_deps(LabelledArrays)
Aqua.test_ambiguities(LabelledArrays, recursive = false, broken = true)
Aqua.test_deps_compat(LabelledArrays)
Aqua.test_piracies(LabelledArrays,
treat_as_own = [])
Aqua.test_project_extras(LabelledArrays)
Aqua.test_stale_deps(LabelledArrays)
Aqua.test_unbound_args(LabelledArrays)
Aqua.test_undefined_exports(LabelledArrays)
end
1 change: 1 addition & 0 deletions test/runtests.jl
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ using InteractiveUtils
using ChainRulesTestUtils

@time begin
@time @testset "Quality Assurance" begin include("qa.jl") end
@time @testset "SLArrays" begin include("slarrays.jl") end
@time @testset "LArrays" begin include("larrays.jl") end
@time @testset "DiffEq" begin include("diffeq.jl") end
Expand Down