Skip to content

rustup: fix regex patterns checkver field #6569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2025

Conversation

huiyifyj
Copy link
Contributor

  • Updated the rustup checkver.url to script link https://sh.rustup.rs.
  • Modified the regex pattern to match rustup version from the installation script.

Relates to #6442


  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

- Updated the rustup `checkver.url` to script link.
- Modified the regex pattern to match rustup version from the installation script.
Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

rustup-gnu

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

rustup-msvc

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

rustup

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

@huiyifyj
Copy link
Contributor Author

huiyifyj commented Mar 6, 2025

It seems no one noticed this PR.
When I opened this PR, rustup was still 1.27.x, rustup has recently been updated to 1.28.1.

The incorrect checkver regex hasn't been updated to the latest version in time

@ddarfantasy
Copy link
Contributor

Any updates? @frabera @niheaven

@huiyifyj
Copy link
Contributor Author

@chawyehsu

@HUMORCE HUMORCE merged commit fa5e8ca into ScoopInstaller:master Apr 16, 2025
3 checks passed
@huiyifyj huiyifyj deleted the fix-regex-rustup branch April 17, 2025 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants