Skip to content

add base svelte template to monorepo #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

lucassshanks
Copy link
Contributor

@lucassshanks lucassshanks commented Mar 3, 2025

CLOUD-78

add default svelte repo

using this as root branch for f/e dashboard so keeping it up to date

@lucassshanks lucassshanks changed the title Create base svelte template in monorepo make base svelte template in monorepo Mar 3, 2025
@lucassshanks lucassshanks changed the title make base svelte template in monorepo add base svelte template to monorepo Mar 4, 2025
@lucassshanks lucassshanks marked this pull request as ready for review March 4, 2025 02:50
@lucassshanks lucassshanks requested a review from a team as a code owner March 4, 2025 02:50
@TroyKomodo
Copy link
Member

We dont allow merge commits, so you must rebase using the cli

@lucassshanks lucassshanks force-pushed the create-base-svelte-template branch 2 times, most recently from a7b638a to a8bb822 Compare March 4, 2025 05:45
@lennartkloock
Copy link
Member

why is the docs deploy failing here?

@lucassshanks lucassshanks changed the title add base svelte template to monorepo CLOUD-78 add base svelte template to monorepo Mar 4, 2025
@lucassshanks lucassshanks changed the title CLOUD-78 add base svelte template to monorepo add base svelte template to monorepo Mar 4, 2025
@lucassshanks lucassshanks force-pushed the create-base-svelte-template branch from a8bb822 to 6781dfb Compare March 4, 2025 23:17
@philipch07 philipch07 marked this pull request as draft April 25, 2025 22:20
@TroyKomodo
Copy link
Member

TroyKomodo commented Apr 25, 2025

@lennartkloock

why is the docs deploy failing here?

i think its something to do with pnpm workspace breaking the pnpm install somehow same issue on #434

Copy link

Deploying scuffle-docusaurus-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: c7f6f1e
Status: ✅  Deploy successful!
Preview URL: https://c0c90adf.scuffle-docusaurus-docs.pages.dev
Branch Preview URL: https://pr-397.scuffle-docusaurus-docs.pages.dev

View logs

Copy link

Deploying scuffle-docrs with  Cloudflare Pages  Cloudflare Pages

Latest commit: c7f6f1e
Status: ✅  Deploy successful!
Preview URL: https://1f3e5ff9.scuffle-docrs.pages.dev
Branch Preview URL: https://pr-397.scuffle-docrs.pages.dev

View logs

Copy link

codecov bot commented May 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.41%. Comparing base (16dcdd9) to head (c7f6f1e).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #397      +/-   ##
==========================================
+ Coverage   83.34%   83.41%   +0.06%     
==========================================
  Files         240      240              
  Lines       17116    17044      -72     
==========================================
- Hits        14266    14217      -49     
+ Misses       2850     2827      -23     

see 7 files with indirect coverage changes

Components Coverage Δ
scuffle-aac 89.65% <ø> (ø)
scuffle-amf0 90.61% <ø> (ø)
scuffle-av1 98.44% <ø> (ø)
scuffle-batching 100.00% <ø> (ø)
scuffle-bootstrap 85.82% <ø> (+1.77%) ⬆️
scuffle-bytes-util 97.04% <ø> (ø)
scuffle-context 100.00% <ø> (ø)
scuffle-expgolomb 100.00% <ø> (ø)
scuffle-ffmpeg 90.91% <ø> (-0.12%) ⬇️
scuffle-flv 95.90% <ø> (ø)
scuffle-future-ext 50.00% <ø> (ø)
nutype-enum 71.87% <ø> (ø)
scuffle-h264 99.69% <ø> (ø)
scuffle-http 86.21% <ø> (ø)
scuffle-metrics 87.29% <ø> (ø)
postcompile 78.81% <ø> (-0.58%) ⬇️
scuffle-pprof 100.00% <ø> (ø)
scuffle-rtmp 91.45% <ø> (-0.40%) ⬇️
scuffle-settings 92.85% <ø> (ø)
scuffle-signal 95.68% <ø> (+10.89%) ⬆️

Copy link
Contributor

github-actions bot commented May 5, 2025

🛫 Startup details 🛫 Revision main not found locally. Fetching from origin...

Checking out commit 16dcdd9 into "target/semver-baseline"

HEAD is now at 16dcdd9 Auto merge of #447 - troy/fix-ci, r=philipch07

📦 Processing crates 📦
  • nutype-enum
  • postcompile
  • scuffle-aac
  • scuffle-amf0
  • scuffle-av1
  • scuffle-batching
  • scuffle-bootstrap
  • scuffle-bootstrap-telemetry
  • scuffle-bytes-util
  • scuffle-context
  • scuffle-expgolomb
  • scuffle-ffmpeg
  • scuffle-flv
  • scuffle-future-ext
  • scuffle-h264
  • scuffle-h265
  • scuffle-http
  • scuffle-metrics
  • scuffle-mp4
  • scuffle-pprof
  • scuffle-rtmp
  • scuffle-settings
  • scuffle-signal
  • scuffle-transmuxer
  • scuffle-workspace-hack
Original semver output:
Building nutype-enum v0.1.3 (current)
   Built [   0.637s] (current)
 Parsing nutype-enum v0.1.3 (current)
  Parsed [   0.004s] (current)
Building nutype-enum v0.1.3 (baseline)
   Built [   0.593s] (baseline)
 Parsing nutype-enum v0.1.3 (baseline)
  Parsed [   0.004s] (baseline)
Checking nutype-enum v0.1.3 -> v0.1.3 (no change)
 Checked [   0.108s] 153 checks: 153 pass, 11 skip
 Summary no semver update required
Finished [   1.742s] nutype-enum
Building postcompile v0.2.0 (current)
   Built [   5.308s] (current)
 Parsing postcompile v0.2.0 (current)
  Parsed [   0.008s] (current)
Building postcompile v0.2.0 (baseline)
   Built [   5.191s] (baseline)
 Parsing postcompile v0.2.0 (baseline)
  Parsed [   0.003s] (baseline)
Checking postcompile v0.2.0 -> v0.2.0 (no change)
 Checked [   0.124s] 153 checks: 153 pass, 11 skip
 Summary no semver update required
Finished [  11.107s] postcompile
Building scuffle-aac v0.1.2 (current)
   Built [   2.567s] (current)
 Parsing scuffle-aac v0.1.2 (current)
  Parsed [   0.006s] (current)
Building scuffle-aac v0.1.2 (baseline)
   Built [   2.358s] (baseline)
 Parsing scuffle-aac v0.1.2 (baseline)
  Parsed [   0.006s] (baseline)
Checking scuffle-aac v0.1.2 -> v0.1.2 (no change)
 Checked [   0.155s] 153 checks: 153 pass, 11 skip
 Summary no semver update required
Finished [   5.498s] scuffle-aac
Building scuffle-amf0 v0.2.0 (current)
   Built [   2.615s] (current)
 Parsing scuffle-amf0 v0.2.0 (current)
  Parsed [   0.013s] (current)
Building scuffle-amf0 v0.2.0 (baseline)
   Built [   2.608s] (baseline)
 Parsing scuffle-amf0 v0.2.0 (baseline)
  Parsed [   0.013s] (baseline)
Checking scuffle-amf0 v0.2.0 -> v0.2.0 (no change)
 Checked [   0.278s] 153 checks: 153 pass, 11 skip
 Summary no semver update required
Finished [   6.061s] scuffle-amf0
Building scuffle-av1 v0.1.2 (current)
   Built [   0.907s] (current)
 Parsing scuffle-av1 v0.1.2 (current)
  Parsed [   0.009s] (current)
Building scuffle-av1 v0.1.2 (baseline)
   Built [   0.909s] (baseline)
 Parsing scuffle-av1 v0.1.2 (baseline)
  Parsed [   0.010s] (baseline)
Checking scuffle-av1 v0.1.2 -> v0.1.2 (no change)
 Checked [   0.227s] 153 checks: 153 pass, 11 skip
 Summary no semver update required
Finished [   2.472s] scuffle-av1
Building scuffle-batching v0.1.2 (current)
   Built [   1.472s] (current)
 Parsing scuffle-batching v0.1.2 (current)
  Parsed [   0.008s] (current)
Building scuffle-batching v0.1.2 (baseline)
   Built [   1.377s] (baseline)
 Parsing scuffle-batching v0.1.2 (baseline)
  Parsed [   0.008s] (baseline)
Checking scuffle-batching v0.1.2 -> v0.1.2 (no change)
 Checked [   0.175s] 153 checks: 153 pass, 11 skip
 Summary no semver update required
Finished [   3.616s] scuffle-batching
Building scuffle-bootstrap v0.1.2 (current)
   Built [   5.191s] (current)
 Parsing scuffle-bootstrap v0.1.2 (current)
  Parsed [   0.006s] (current)
Building scuffle-bootstrap v0.1.2 (baseline)
   Built [   5.395s] (baseline)
 Parsing scuffle-bootstrap v0.1.2 (baseline)
  Parsed [   0.007s] (baseline)
Checking scuffle-bootstrap v0.1.2 -> v0.1.2 (no change)
 Checked [   0.140s] 153 checks: 153 pass, 11 skip
 Summary no semver update required
Finished [  11.434s] scuffle-bootstrap
Building scuffle-bootstrap-telemetry v0.2.1 (current)
   Built [   8.568s] (current)
 Parsing scuffle-bootstrap-telemetry v0.2.1 (current)
  Parsed [   0.016s] (current)
Building scuffle-bootstrap-telemetry v0.2.1 (baseline)
   Built [   8.673s] (baseline)
 Parsing scuffle-bootstrap-telemetry v0.2.1 (baseline)
  Parsed [   0.015s] (baseline)
Checking scuffle-bootstrap-telemetry v0.2.1 -> v0.2.1 (no change)
 Checked [   0.114s] 153 checks: 153 pass, 11 skip
 Summary no semver update required
Finished [  19.305s] scuffle-bootstrap-telemetry
Building scuffle-bytes-util v0.1.2 (current)
   Built [   1.841s] (current)
 Parsing scuffle-bytes-util v0.1.2 (current)
  Parsed [   0.010s] (current)
Building scuffle-bytes-util v0.1.2 (baseline)
   Built [   1.645s] (baseline)
 Parsing scuffle-bytes-util v0.1.2 (baseline)
  Parsed [   0.006s] (baseline)
Checking scuffle-bytes-util v0.1.2 -> v0.1.2 (no change)
 Checked [   0.165s] 153 checks: 153 pass, 11 skip
 Summary no semver update required
Finished [   4.550s] scuffle-bytes-util
Building scuffle-context v0.1.2 (current)
   Built [   1.052s] (current)
 Parsing scuffle-context v0.1.2 (current)
  Parsed [   0.008s] (current)
Building scuffle-context v0.1.2 (baseline)
   Built [   1.070s] (baseline)
 Parsing scuffle-context v0.1.2 (baseline)
  Parsed [   0.008s] (baseline)
Checking scuffle-context v0.1.2 -> v0.1.2 (no change)
 Checked [   0.137s] 153 checks: 153 pass, 11 skip
 Summary no semver update required
Finished [   2.827s] scuffle-context
Building scuffle-expgolomb v0.1.2 (current)
   Built [   0.832s] (current)
 Parsing scuffle-expgolomb v0.1.2 (current)
  Parsed [   0.004s] (current)
Building scuffle-expgolomb v0.1.2 (baseline)
   Built [   0.835s] (baseline)
 Parsing scuffle-expgolomb v0.1.2 (baseline)
  Parsed [   0.002s] (baseline)
Checking scuffle-expgolomb v0.1.2 -> v0.1.2 (no change)
 Checked [   0.100s] 153 checks: 153 pass, 11 skip
 Summary no semver update required
Finished [   2.142s] scuffle-expgolomb
Building scuffle-ffmpeg v0.3.0 (current)
   Built [  10.914s] (current)
 Parsing scuffle-ffmpeg v0.3.0 (current)
  Parsed [   0.056s] (current)
Building scuffle-ffmpeg v0.3.0 (baseline)
   Built [   9.361s] (baseline)
 Parsing scuffle-ffmpeg v0.3.0 (baseline)
  Parsed [   0.035s] (baseline)
Checking scuffle-ffmpeg v0.3.0 -> v0.3.0 (no change)
 Checked [   1.898s] 153 checks: 153 pass, 11 skip
 Summary no semver update required
Finished [  23.590s] scuffle-ffmpeg
Building scuffle-flv v0.2.0 (current)
   Built [   3.990s] (current)
 Parsing scuffle-flv v0.2.0 (current)
  Parsed [   0.012s] (current)
Building scuffle-flv v0.2.0 (baseline)
   Built [   3.976s] (baseline)
 Parsing scuffle-flv v0.2.0 (baseline)
  Parsed [   0.012s] (baseline)
Checking scuffle-flv v0.2.0 -> v0.2.0 (no change)
 Checked [   0.590s] 153 checks: 153 pass, 11 skip
 Summary no semver update required
Finished [   9.166s] scuffle-flv
Building scuffle-future-ext v0.1.2 (current)
   Built [   0.673s] (current)
 Parsing scuffle-future-ext v0.1.2 (current)
  Parsed [   0.002s] (current)
Building scuffle-future-ext v0.1.2 (baseline)
   Built [   0.682s] (baseline)
 Parsing scuffle-future-ext v0.1.2 (baseline)
  Parsed [   0.002s] (baseline)
Checking scuffle-future-ext v0.1.2 -> v0.1.2 (no change)
 Checked [   0.098s] 153 checks: 153 pass, 11 skip
 Summary no semver update required
Finished [   1.908s] scuffle-future-ext
Building scuffle-h264 v0.2.0 (current)
   Built [   0.889s] (current)
 Parsing scuffle-h264 v0.2.0 (current)
  Parsed [   0.010s] (current)
Building scuffle-h264 v0.2.0 (baseline)
   Built [   0.960s] (baseline)
 Parsing scuffle-h264 v0.2.0 (baseline)
  Parsed [   0.010s] (baseline)
Checking scuffle-h264 v0.2.0 -> v0.2.0 (no change)
 Checked [   0.199s] 153 checks: 153 pass, 11 skip
 Summary no semver update required
Finished [   2.455s] scuffle-h264
Building scuffle-h265 v0.2.0 (current)
   Built [   0.991s] (current)
 Parsing scuffle-h265 v0.2.0 (current)
  Parsed [   0.019s] (current)
Building scuffle-h265 v0.2.0 (baseline)
   Built [   0.992s] (baseline)
 Parsing scuffle-h265 v0.2.0 (baseline)
  Parsed [   0.019s] (baseline)
Checking scuffle-h265 v0.2.0 -> v0.2.0 (no change)
 Checked [   0.483s] 153 checks: 153 pass, 11 skip
 Summary no semver update required
Finished [   2.933s] scuffle-h265
Building scuffle-http v0.2.1 (current)
   Built [  14.371s] (current)
 Parsing scuffle-http v0.2.1 (current)
  Parsed [   0.036s] (current)
Building scuffle-http v0.2.1 (baseline)
   Built [  14.412s] (baseline)
 Parsing scuffle-http v0.2.1 (baseline)
  Parsed [   0.031s] (baseline)
Checking scuffle-http v0.2.1 -> v0.2.1 (no change)
 Checked [   0.425s] 153 checks: 153 pass, 11 skip
 Summary no semver update required
Finished [  31.177s] scuffle-http
Building scuffle-metrics v0.2.0 (current)
   Built [   4.670s] (current)
 Parsing scuffle-metrics v0.2.0 (current)
  Parsed [   0.012s] (current)
Building scuffle-metrics v0.2.0 (baseline)
   Built [   4.709s] (baseline)
 Parsing scuffle-metrics v0.2.0 (baseline)
  Parsed [   0.012s] (baseline)
Checking scuffle-metrics v0.2.0 -> v0.2.0 (no change)
 Checked [   0.168s] 153 checks: 153 pass, 11 skip
 Summary no semver update required
Finished [  10.296s] scuffle-metrics
Building scuffle-mp4 v0.1.2 (current)
   Built [   5.140s] (current)
 Parsing scuffle-mp4 v0.1.2 (current)
  Parsed [   0.026s] (current)
Building scuffle-mp4 v0.1.2 (baseline)
   Built [   5.053s] (baseline)
 Parsing scuffle-mp4 v0.1.2 (baseline)
  Parsed [   0.056s] (baseline)
Checking scuffle-mp4 v0.1.2 -> v0.1.2 (no change)
 Checked [   1.549s] 153 checks: 153 pass, 11 skip
 Summary no semver update required
Finished [  12.897s] scuffle-mp4
Building scuffle-pprof v0.1.2 (current)
   Built [   6.126s] (current)
 Parsing scuffle-pprof v0.1.2 (current)
  Parsed [   0.009s] (current)
Building scuffle-pprof v0.1.2 (baseline)
   Built [   5.902s] (baseline)
 Parsing scuffle-pprof v0.1.2 (baseline)
  Parsed [   0.009s] (baseline)
Checking scuffle-pprof v0.1.2 -> v0.1.2 (no change)
 Checked [   0.111s] 153 checks: 153 pass, 11 skip
 Summary no semver update required
Finished [  13.871s] scuffle-pprof
Building scuffle-rtmp v0.2.0 (current)
   Built [   4.320s] (current)
 Parsing scuffle-rtmp v0.2.0 (current)
  Parsed [   0.015s] (current)
Building scuffle-rtmp v0.2.0 (baseline)
   Built [   4.527s] (baseline)
 Parsing scuffle-rtmp v0.2.0 (baseline)
  Parsed [   0.033s] (baseline)
Checking scuffle-rtmp v0.2.0 -> v0.2.0 (no change)
 Checked [   0.674s] 153 checks: 153 pass, 11 skip
 Summary no semver update required
Finished [  10.565s] scuffle-rtmp
Building scuffle-settings v0.1.2 (current)
   Built [   6.739s] (current)
 Parsing scuffle-settings v0.1.2 (current)
  Parsed [   0.012s] (current)
Building scuffle-settings v0.1.2 (baseline)
   Built [   6.923s] (baseline)
 Parsing scuffle-settings v0.1.2 (baseline)
  Parsed [   0.012s] (baseline)
Checking scuffle-settings v0.1.2 -> v0.1.2 (no change)
 Checked [   0.123s] 153 checks: 153 pass, 11 skip
 Summary no semver update required
Finished [  14.760s] scuffle-settings
Building scuffle-signal v0.3.0 (current)
   Built [   5.402s] (current)
 Parsing scuffle-signal v0.3.0 (current)
  Parsed [   0.009s] (current)
Building scuffle-signal v0.3.0 (baseline)
   Built [   5.378s] (baseline)
 Parsing scuffle-signal v0.3.0 (baseline)
  Parsed [   0.010s] (baseline)
Checking scuffle-signal v0.3.0 -> v0.3.0 (no change)
 Checked [   0.128s] 153 checks: 153 pass, 11 skip
 Summary no semver update required
Finished [  11.634s] scuffle-signal
Building scuffle-transmuxer v0.2.0 (current)
   Built [   5.450s] (current)
 Parsing scuffle-transmuxer v0.2.0 (current)
  Parsed [   0.014s] (current)
Building scuffle-transmuxer v0.2.0 (baseline)
   Built [   5.532s] (baseline)
 Parsing scuffle-transmuxer v0.2.0 (baseline)
  Parsed [   0.015s] (baseline)
Checking scuffle-transmuxer v0.2.0 -> v0.2.0 (no change)
 Checked [   0.212s] 153 checks: 153 pass, 11 skip
 Summary no semver update required
Finished [  11.831s] scuffle-transmuxer
Building scuffle-workspace-hack v0.1.0 (current)
   Built [   0.514s] (current)
 Parsing scuffle-workspace-hack v0.1.0 (current)
  Parsed [   0.004s] (current)
Building scuffle-workspace-hack v0.1.0 (baseline)
   Built [  28.584s] (baseline)
 Parsing scuffle-workspace-hack v0.1.0 (baseline)
  Parsed [   0.009s] (baseline)
Checking scuffle-workspace-hack v0.1.0 -> v0.1.0 (no change)
 Checked [   0.104s] 153 checks: 153 pass, 11 skip
 Summary no semver update required
Finished [  30.146s] scuffle-workspace-hack

Semver-checks summary

✅ No semver violations found! ✅

🛬 Cleanup details 🛬

Cleaning up git worktree at "target/semver-baseline"

Successfully removed git worktree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants