Automatic test#17802 #26
Conversation
1. map:path series 2. map:poi series 3. map:subsite series 4. map:view series
1. map:compensation series 2. map:die series
…ntioProberDev/SentioProberControl into David.Liu/AutomaticTest#17802
…ntioProberDev/SentioProberControl into David.Liu/AutomaticTest#17802
| @@ -187,13 +186,11 @@ def start_prepare_station(self, station: LoaderStation, angle: float | None = No | |||
| return Response.check_resp(self.comm.read_line()) | |||
|
|
|||
|
|
|||
| @deprecated("duplicate functionality; Use SentioProber.move_chuck_work_area!") | |||
| def switch_work_area(self, area: str): | |||
There was a problem hiding this comment.
This function is a duplication of the fiunctionality of move_chuck_work_area. Its name violates the rule that the python api names should match remote command names. Therefore it has been marked as deprecated.
Is there a reason to remove the deprecation marker?
|
|
||
| def set_chuck_thermo_energy_mode(self, mode: str) -> Response: | ||
| def set_chuck_thermo_energy_mode(self, mode: Union[str, ChuckThermoEnergyMode]) -> Response: |
There was a problem hiding this comment.
In order to keep the python API simple and unambiguous we should be as clear in the types of our input parameters as possible. Therefore we should only except enums if we have an enumerator that contains all available options.
I have filed a CR ticket: https://ast-svn.mpi.com.tw/redmine/issues/18176
We do not want the scripts on the client site to diverge in order to keep out code maintainable,
| return Response.check_resp(self.comm.read_line()) | ||
|
|
||
| def set_chuck_thermo_hold_mode(self, mode: bool) -> Response: | ||
| def set_chuck_thermo_hold_mode(self, mode: Union[bool, ChuckThermoHoldMode, str]) -> Response: |
There was a problem hiding this comment.
Should not return a response object because it is not an async function,
| """ | ||
| self.comm.send("qal:get_calibration_status") | ||
| resp = Response.check_resp(self.comm.read_line()) | ||
| return resp.message() | ||
| status = resp.message().strip() | ||
| if status.upper() != "OK": |
There was a problem hiding this comment.
I dont think this logic ever triggers because get_calibration status will return an error code if something is off. At least if the remote command specification is correct.
In general i would oppose parsing remote command response strings to determine wether an action failed or not because this will break if someone in the future decides that SENTIO will return something alse then "ok". Please rely on error codes.
| """ | ||
| Clear network data for a DUT. | ||
|
|
||
| Wraps SENTIO's "qal:clear_dut_network" remote command. | ||
|
|
||
| Args: | ||
| dut_name: The name of the DUT (e.g. "RefDUT"). | ||
| drift_type: The type of drift data to clear ("DriftRef" or "Drift"). | ||
| drift_type: The type of drift data to clear (DriftType.DriftRef or DriftType.Drift). |
There was a problem hiding this comment.
Please specify the type as requested by google docstyle format: "drift_type (DriftType)" . The system we are using to create the documentation needs this information to create the proper links in the API documentation.
| return Response.check_resp(self.comm.read_line()) | ||
|
|
||
| def set_signal_tower_buzzer(self, state: int) -> Response: |
There was a problem hiding this comment.
Should not have a return type
| return Response.check_resp(self.comm.read_line()) | ||
|
|
||
| def start_move_indexer_pos(self, pos: int) -> Response: |
There was a problem hiding this comment.
Should not have a return type
| return Response.check_resp(self.comm.read_line()) | ||
|
|
||
| def swap_bridge(self, side: str, device_position: str = None) -> Response: |
There was a problem hiding this comment.
Should not have a return type
| return closed == "1", locked == "1" | ||
|
|
||
| def set_door_lock(self, door: str, lock: bool) -> Response: |
There was a problem hiding this comment.
Should not have a return type
There was a problem hiding this comment.
I did not review the test code; The PR is too large therfore my Focus is on production code.
[python script] update the missing API for python package