configurable actor, environment, data loader #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rizar
changed the title
AlexPiche
approved these changes
May 29, 2025
pipelinerl/run_preprocess.py
Outdated
| @@ -405,8 +402,10 @@ def run_preprocessing_loop( | |||
| stats = { | |||
| "preprocessor/published_samples": published_samples, | |||
| "preprocessor/published_model_version": max_model_version, | |||
| "preprocessor/samples_in_input_queue": raw_chunk_queue.qsize() * cfg.preprocess.chunk_size, | |||
| "preprocessor/samples_in_output_queue": samples_in_queue, | |||
| "processossor/queue/raw_samples": raw_chunk_queue.qsize() * cfg.preprocess.chunk_size, | |||
There was a problem hiding this comment.
yeah it would make a lot of sense to have examples someplace separate, but in practice right now it creates no pain, so let's do this when it does create pain
| reward = 0 # TODO: implement verifier usage and reward calculation | ||
| metrics = { | ||
| "reward": reward, | ||
| "success": reward > 0, |
There was a problem hiding this comment.
not sure we want to hard code success as reward greater than 0.
There was a problem hiding this comment.
this is not finished anyway
| @@ -238,6 +240,24 @@ def wait_for_inference_servers(urls: list[str]): | |||
| logger.info("All inference servers are up") | |||
|
|
|||
|
|
|||
| def wait_for_environments(cfg: DictConfig): | |||
There was a problem hiding this comment.
can we re-use wait_for_inference_servers?
There was a problem hiding this comment.
true, we could reuse some code here... too lazy to fix this right now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
includes #23