Skip to content

Make isItemViewable handle floating point error. #1029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Make isItemViewable handle floating point error. #1029

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43baad0
Make isItemViewable handle floating point error.
tpcstld Jan 17, 2024
4f201db
empty commit for CLA
tpcstld Feb 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ and adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

## [Unreleased]

- Make `onViewableItemsChanged` better handle floating-point error.

## [1.6.3] - 2023-11-09

- Changes for RN 0.73 support
Expand Down
3 changes: 2 additions & 1 deletion src/viewability/ViewabilityHelper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,8 @@ class ViewabilityHelper {
Math.min(itemTop + itemSize, listMainSize) - Math.max(itemTop, 0);

// Always consider item fully viewable if it is fully visible, regardless of the `viewAreaCoveragePercentThreshold`
if (pixelsVisible === itemSize) {
// Account for floating point imprecision.
if (Math.abs(pixelsVisible - itemSize) <= 0.001) {
return true;
}
// Skip checking item if it's not visible at all
Expand Down