Skip to content
This repository was archived by the owner on May 30, 2024. It is now read-only.

Add support for YAML HEREDOC highlighting #843

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Add support for YAML HEREDOC highlighting #843

merged 1 commit into from
Oct 20, 2023

Conversation

sambostock
Copy link
Contributor

@sambostock sambostock commented Oct 18, 2023

Motivation

This adds support for YAML syntax highlighting in HEREDOCs.

Implementation

TDD: The tests added in #842 were updated, and the config file was updated to make them pass.

Automated Tests

TDD

Manual Tests

See the last column in this table.

GitHub VSCode
Raw YAML HEREDOC Raw YAML HEREDOC Before HEREDOC After
<<~YAML
foo:
  - [123, abc]
  - [true, "false"]
  - { xyz: null}
YAML
foo:
  - [123, abc]
  - [true, "false"]
  - { xyz: null}
image image image

Before Merging

Base automatically changed from heredoc-pattern-tests to main October 19, 2023 19:51
@sambostock sambostock marked this pull request as ready for review October 20, 2023 01:05
@sambostock sambostock requested a review from a team as a code owner October 20, 2023 01:05
@vinistock
Copy link
Member

Awesome!

@vinistock vinistock merged commit d7236a7 into main Oct 20, 2023
@vinistock vinistock deleted the heredoc-yaml branch October 20, 2023 17:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants