Skip to content

fix: increased carousel navigation button size to 52x52px (#8959) #9784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

pegasus991
Copy link

@pegasus991 pegasus991 commented Apr 7, 2025

This PR resolves issue #8959 by increasing the size of the carousel navigation buttons (left/right arrows) to 52x52px, improving clickability and visibility for users browsing agent cards.

Changes 🏗️

  • Increased button size for CarouselPrevious and CarouselNex` in autogpt_platform/frontend/src/components/ui/carousel.tsx
  • Changed Tailwind classes from h-[38px] w-[38px]toh-[52px] w-[52px]
  • Optionally adjusted icon size to better fit the new container

Checklist 📋

For code changes:

  • I have clearly listed my changes in the PR description
  • I have made a test plan
  • I have tested my changes according to the test plan:
    • Viewed carousel on /marketplace page in local dev environment
    • Verified that navigation buttons render at the new size
    • Confirmed layout is not broken
Example test plan
  • Create from scratch and execute an agent with at least 3 blocks
  • Import an agent from file upload, and confirm it executes correctly
  • Upload agent to marketplace
  • Import an agent from marketplace and confirm it executes correctly
  • Edit an agent from monitor, and confirm it executes correctly

For configuration changes:

  • .env.example is updated or already compatible with my changes
  • docker-compose.yml is updated or already compatible with my changes
  • I have included a list of my configuration changes in the PR description (under Changes)
Examples of configuration changes
  • Changing ports
  • Adding new services that need to communicate with each other
  • Secrets or environment variable changes
  • New or infrastructure changes such as databases

@pegasus991 pegasus991 requested a review from a team as a code owner April 7, 2025 21:57
@pegasus991 pegasus991 requested review from Bentlybro and aarushik93 and removed request for a team April 7, 2025 21:57
@github-project-automation github-project-automation bot moved this to 🆕 Needs initial review in AutoGPT development kanban Apr 7, 2025
@CLAassistant
Copy link

CLAassistant commented Apr 7, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

github-actions bot commented Apr 7, 2025

This PR targets the master branch but does not come from dev or a hotfix/* branch.

Automatically setting the base branch to dev.

@github-actions github-actions bot changed the base branch from master to dev April 7, 2025 21:58
@github-actions github-actions bot added size/s platform/frontend AutoGPT Platform - Front end platform/backend AutoGPT Platform - Back end and removed size/s labels Apr 7, 2025
@qodo-merge-pro qodo-merge-pro bot added size/s Review effort 1/5 and removed platform/frontend AutoGPT Platform - Front end platform/backend AutoGPT Platform - Back end labels Apr 7, 2025
Copy link

qodo-merge-pro bot commented Apr 7, 2025

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis ✅

8959 - PR Code Verified

Compliant requirements:

• Increase the size of the circular navigation buttons from 38x38 to 52x52px

Requires further human verification:

• Visual verification that the buttons are now 52x52px as specified in the ticket

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Button Size Mismatch

The PR changes the icon size from h-8/w-8 to h-10/w-10, but doesn't explicitly change the button container size to 52x52px as required by the ticket.

<ChevronLeft className="h-10 w-10" strokeWidth={1.25} />
<span className="sr-only">Previous slide</span>
Button Size Mismatch

The PR changes the icon size from h-8/w-8 to h-10/w-10, but doesn't explicitly change the button container size to 52x52px as required by the ticket.

<ChevronRight className="h-10 w-10" strokeWidth={1.25} />
<span className="sr-only">Next slide</span>

Copy link

deepsource-io bot commented Apr 7, 2025

Here's the code health analysis summary for commits d316ed2..17ca764. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗
DeepSource Python LogoPython✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link

netlify bot commented Apr 7, 2025

Deploy Preview for auto-gpt-docs canceled.

Name Link
🔨 Latest commit 17ca764
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/67f44a5e0ca4a7000806a880

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🆕 Needs initial review
Development

Successfully merging this pull request may close these issues.

3 participants