Mitigate deserialization errors due to hub 0.57 FW bug #2218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0.57 FW has an extra byte as the first byte of zdo message body payloads and is missing the last byte of the body of the payload. This adds a mitigation in the ZdoMessageBody deserialization code which overrides the Lua library function that corrects the off by 1 error and inserts a default last byte of 0x01 for every Zdo message payload.
cjswedes
commented
Jun 25, 2025
Comment on lines
+99
to
+106
| -- there is a bug in hub FW that causes the zdo message payload to have an invalid first byte | ||
| -- and a missing last byte. Default to adding in a 1, which is a good default for the mgmt_bind_response | ||
| -- binding table entry endpoint_id | ||
| local version = require "version" | ||
| if version.rpc == 8 then | ||
| buf.buf = buf.buf .. "\01" | ||
| buf:seek(1) | ||
| end |
There was a problem hiding this comment.
Here is where the mitigation occurs
|
Channel deleted. |
Test Results 68 files 444 suites 0s ⏱️ Results for commit eb46158. |
|
zigbee-button_coverage.xml
zigbee-motion-sensor_coverage.xml
Minimum allowed coverage is Generated by 🐒 cobertura-action against eb46158 |
greens
approved these changes
Jun 25, 2025
|
One thing I realized this doesnt address is that any device that was joined while this is broken will remain non functional until it requests the binding table (is reconfigured). I think the approach that I will take is to do a one time reconfiguration of all devices in these subdrivers by setting the provisioning state to TYPED. |
varzac
approved these changes
Jun 25, 2025
I would be concerned that the reconfiguration could cause more problems that it solves, and I would just suggest that we ask people to re-onboard their devices if the functionality is affected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0.57 FW has an extra byte as the first byte of zdo message body payloads and is missing the last byte of the body of the payload. This adds a mitigation in the ZdoMessageBody deserialization code which overrides the Lua library function to correct the off by 1 error and inserts a default last byte of 0x01 for every Zdo message payload.
Testing