Chapter 2: Fix 'make dir' test #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

Sobeston merged 1 commit into Sobeston:master from sigod:patch-1

Sep 11, 2023

Contributor

sigod commented May 7, 2023

Without this I get

Test [1/1] test.make dir... thread 34048 panic: attempt to unwrap error: FileBusy
C:\Users\sigod\AppData\Local\zig\lib\std\os\windows.zig:922:31: 0x7ff722d6aeea in DeleteFile (test.exe.obj)
        .SHARING_VIOLATION => return error.FileBusy,
                              ^


          Chapter 2: Fix 'make dir' test

e12c1f0

Contributor Author

sigod commented May 7, 2023

Also, this test creates files, but doesn't close them:

    _ = try iter_dir.dir.createFile("x", .{});
    _ = try iter_dir.dir.createFile("y", .{});
    _ = try iter_dir.dir.createFile("z", .{});

Combined with ziglang/zig#15465 it causes the test to hang.

Sobeston merged commit 30363f3 into Sobeston:master

sigod deleted the patch-1 branch

September 11, 2023 19:02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet