Skip to content

Issue(14533): Handled duplicate call which causing typeahead to execute in wrong page #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: Angular_DeliteRemoval
Choose a base branch
from
Draft

Issue(14533): Handled duplicate call which causing typeahead to execute in wrong page #54

wants to merge 2 commits into from

Conversation

Prem-Chitanand12
Copy link
Collaborator

PR contains:

  • Removed duplicate API call from ngOnInit() lifecycle function

@Prem-Chitanand12
Copy link
Collaborator Author

image
Tested the changes and it is working as expected

IdanSAG
IdanSAG requested changes Apr 17, 2025
View reviewed changes
Copy link
Collaborator

@IdanSAG IdanSAG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel that if we omit the postGetScreen(..) call, a new screen will not be rendered in case the screen spontaneously update in the host side

@IdanSAG IdanSAG self-requested a review April 17, 2025 10:23
snayak-dev
snayak-dev reviewed Apr 21, 2025
View reviewed changes
Copy link
Collaborator

@snayak-dev snayak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes looks good , if possible, please add unit tests .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snayak-dev snayak-dev snayak-dev left review comments

@IdanSAG IdanSAG IdanSAG approved these changes

@vinoth-rajendran vinoth-rajendran Awaiting requested review from vinoth-rajendran

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Prem-Chitanand12 @IdanSAG @snayak-dev