fix: missing constants and AtomicU64 for --all-features on riscv32 target #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
error[E0425]: cannot find value `TCB_SIZE` in this scope
--> src/tls.rs:139:9
|
139 | TCB_SIZE + GAP_ABOVE_TP
| ^^^^^^^^ not found in this scope
taskctx $ cargo c --all-features --target riscv32imafc-unknown-none-elf
Compiling taskctx v0.1.0 (/rust/tmp/repos/taskctx)
error[E0432]: unresolved import `core::sync::atomic::AtomicU64`
--> src/task.rs:12:53
|
12 | sync::atomic::{AtomicBool, AtomicI32, AtomicU8, AtomicU64, AtomicUsize, Ordering},
| ^^^^^^^^^
| |
| no `AtomicU64` in `sync::atomic`
| help: a similar name exists in the module: `AtomicU32`
Changes:
* struct TaskId(u64) => struct TaskId(usize)
* static ID_COUNTER: AtomicU64 => static ID_COUNTER: AtomicUsize
* process_id: AtomicU64 => process_id: AtomicUsize
* set_child_tid: AtomicU64 => set_child_tid: AtomicUsize
* clear_child_tid: AtomicU64 => clear_child_tid: AtomicUsize
* cpu_set: AtomicU64 => cpu_set: AtomicUsize
zjp-CN
added a commit
to os-checker/dockerfiles
that referenced
this pull request
Dec 31, 2024
zjp-CN
added a commit
to os-checker/naked_fn
that referenced
this pull request
Dec 31, 2024
Azure-stars
approved these changes
Jan 2, 2025
Azure-stars
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For context: #10 (comment)
This PR includes
unrecognized instruction mnemonicfor riscv code on latest nightly rustc, but no error on a bit older toolchain nightly-2024-12-04. This has been reported to Rust repo met unrecognized instruction mnemonic error when naked function uses macro defined in global_asm! rust-lang/rust#134960 .