feat(ui): add support for custom html tag rendering in markdown #4091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for custom HTML tag rendering in Markdown by introducing new functionality for formatting tags and integrating custom tag handling in Markdown components. Key changes include:
- A new utility function to format custom markdown tags in chat messages.
- Addition of a custom strip tags plugin to escape non-whitelisted HTML tags.
- Updates to Markdown and MessageMarkdown components to integrate the new custom tag handling.
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| ee/tabby-ui/lib/utils/chat.ts | Added formatMarkdownCustomTags function to adjust newlines for custom HTML tags. |
| ee/tabby-ui/lib/constants/index.ts | Added MARKDOWN_CUSTOM_TAGS constant for whitelisting custom markdown tags. |
| ee/tabby-ui/components/message-markdown/index.tsx | Integrated custom tag formatting and added a custom React component for rendering 'think'. |
| ee/tabby-ui/components/message-markdown/custom-strip-tags-plugin.ts | Introduced a plugin to escape HTML tags not in the whitelist. |
| ee/tabby-ui/components/markdown.tsx | Extended markdown options to support custom HTML tag rendering. |
Files not reviewed (1)
- ee/tabby-ui/package.json: Language not supported
| export function customStripTagsPlugin() { | ||
| return function (tree: Root) { | ||
| visit(tree, 'raw', (node: Raw) => { | ||
| node.value = node.value.replace(tagFilterExpression, '<$2$3') |
There was a problem hiding this comment.
[nitpick] The replacement string omits the leading slash captured as group1, which may lead to incorrect escaping of closing tags. Consider changing the replacement to include group1 (e.g., '<$1$3').
Suggested change
| node.value = node.value.replace(tagFilterExpression, '<$2$3') | |
| node.value = node.value.replace(tagFilterExpression, '<$1$2$3') |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
liangfung
force-pushed
the
feat-ui-support-custom-html-tag-rendering
branch
from
bd1fa35 to
a8dac96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on #4075
cc @JovenSoh