Skip to content

feat(core): debounced form listeners #1463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 27, 2025

Conversation

harry-whorlow
Copy link
Contributor

@harry-whorlow harry-whorlow commented Apr 27, 2025

Follow up from #1261, and the request made in issue #1261, from this comment. This PR ads listeners debouncing at a form level.

Copy link

nx-cloud bot commented Apr 27, 2025

View your CI Pipeline Execution ↗ for commit 18e3d75.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 1m 43s View ↗
nx run-many --target=build --exclude=examples/** ✅ Succeeded 22s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-27 12:31:31 UTC

Copy link

pkg-pr-new bot commented Apr 27, 2025

More templates

@tanstack/angular-form

npm i https://pkg.pr.new/@tanstack/angular-form@1463

@tanstack/form-core

npm i https://pkg.pr.new/@tanstack/form-core@1463

@tanstack/lit-form

npm i https://pkg.pr.new/@tanstack/lit-form@1463

@tanstack/react-form

npm i https://pkg.pr.new/@tanstack/react-form@1463

@tanstack/solid-form

npm i https://pkg.pr.new/@tanstack/solid-form@1463

@tanstack/svelte-form

npm i https://pkg.pr.new/@tanstack/svelte-form@1463

@tanstack/vue-form

npm i https://pkg.pr.new/@tanstack/vue-form@1463

commit: 18e3d75

@harry-whorlow harry-whorlow force-pushed the debounce-form-listeners branch from 52fbdda to 4252f15 Compare April 27, 2025 12:16
Copy link

codecov bot commented Apr 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.97%. Comparing base (9f68452) to head (18e3d75).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1463      +/-   ##
==========================================
+ Coverage   88.86%   88.97%   +0.11%     
==========================================
  Files          31       31              
  Lines        1383     1397      +14     
  Branches      347      353       +6     
==========================================
+ Hits         1229     1243      +14     
  Misses        137      137              
  Partials       17       17              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@harry-whorlow harry-whorlow marked this pull request as ready for review April 27, 2025 12:25
@harry-whorlow harry-whorlow merged commit cc06a6b into TanStack:main Apr 27, 2025
6 checks passed
@harry-whorlow
Copy link
Contributor Author

@Balastrong thanks for the review!! enjoy the Sunday

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants