Skip to content

feat(react-router,solid-router): preloadIntentProximity #4122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

feat(react-router,solid-router): preloadIntentProximity #4122

wants to merge 4 commits into from

Conversation

birkskyum
Copy link
Member

@birkskyum birkskyum commented May 9, 2025 •
edited
Loading

This is the react impl., taken from the devinxi branch

Draft of a Solid impl. added too

Tests are missing.

@birkskyum birkskyum marked this pull request as draft May 9, 2025 12:34
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented May 9, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit eaac2c5.

Command Status Duration Result
nx run-many --target=build --exclude=examples/*... ❌ Failed 8s View ↗
nx affected --targets=test:eslint,test:unit,tes... ✅ Succeeded 55s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-09 15:46:45 UTC

birkskyum added a commit that referenced this pull request May 9, 2025
@birkskyum
move the preloadIntentProximity to separate pr #4122
3d2e716
@birkskyum birkskyum changed the title preloadIntentProximity feat(react-router,solid-router): preloadIntentProximity May 9, 2025
@schiller-manuel
Copy link
Contributor

docs are also missing :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package: react-router package: solid-router
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@birkskyum @schiller-manuel