fix(router-core, start-client-core): Additional types to help with types in head and warning in dev if unexpected keys provided.
#4241
+134
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zrosenbauer
changed the title
head and warning in dev if unexpected keys provided.head and warning in dev if unexpected keys provided.
|
View your CI Pipeline Execution ↗ for commit 38ef84b.
☁️ Nx Cloud last updated this comment at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to provide some feedback to the developer if they provide unexpected keys to the head property.
source: https://discord.com/channels/719702312431386674/1372533009563258880
FYI if someone knows how to enforce the shape for a function like this without having super complex generics I'm all for it.