You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow-up to #961. The original issue still occurs when there's only one item in a multi-lane layout.
This PR changes the loop condition in getTotalSize() to handle cases where only one item exists in multi-lane. The previous condition skipped the loop when endIndex === 0, which caused the total size to be incorrectly calculated as 0.
I used the following test to verify the fix locally:
test("should return correct total size with single item in multi-lane",()=>{constvirtualizer=newVirtualizer({count: 1,lanes: 2,getScrollElement: ()=>null,estimateSize: ()=>50,scrollToFn: vi.fn(),observeElementRect: vi.fn(),observeElementOffset: vi.fn(),});expect(virtualizer.getTotalSize()).toBe(50);});
This is a fairly specific edge case, so I didn’t include the test in the commit.
Happy to add it if you think it’d be useful to include in the suite!
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Thanks, @greenblues1190! Let's add the test. Overall, the tests need some attention. The plan is to refactor the current unit tests a bit and add browser testing using Playwright.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #961. The original issue still occurs when there's only one item in a multi-lane layout.
This PR changes the loop condition in
getTotalSize()to handle cases where only one item exists in multi-lane. The previous condition skipped the loop whenendIndex === 0, which caused the total size to be incorrectly calculated as 0.I used the following test to verify the fix locally:
This is a fairly specific edge case, so I didn’t include the test in the commit.
Happy to add it if you think it’d be useful to include in the suite!
Fixes #963