Skip to content

Fix/alembic ignore bigquery #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 29 commits into from
May 14, 2025
Merged

Fix/alembic ignore bigquery #220

merged 29 commits into from
May 14, 2025

Conversation

MiNeves00
Copy link
Collaborator

@MiNeves00 MiNeves00 commented May 13, 2025 •
edited
Loading

LLMstudio Version X.X.X

What was done in this PR:

  • Applying Alembic migrations is ignored and not act if the DB_TYPE is BigQuery since its not supported. Generating migrations for BigQuery raises an error
  • Corrected a bug with the auto running alembic upgrade head path on tracker server startup

How it was tested:

  1. change env var LLMSTUDIO_TRACKING_URI="bigquery:///./llmstudio_mgmt.db"
  2. poetry run alembic upgrade head
    Should be skipped
  3. poetry run alembic revision --autogenerate -m "describe your change"
    Should raise an error
  • Passed all integration tests

MiNeves00 added 22 commits May 5, 2025 12:13
@MiNeves00
feat: refactored tracker db folder structure. added alembic migrations
f1cd9ec
@MiNeves00
added tracker logs integration test. added alembic check of migration…
88b7231 
… consistency to actions
@MiNeves00
fix: fixed the test actions for alembic
196e868
@MiNeves00
fix: fixed path for script on the test actions for alembic
630871f
@MiNeves00
fix: addded tracker dependencies to integration test action
d1817a8
@MiNeves00
fix: integration test action installation of tracker
c46ab31
@MiNeves00
fix: integration test action cache poetry of tracker
5439806
@MiNeves00
chore: updated llmstudio lib poetry lock
ef5dd14
@MiNeves00
fix: integration test action changed working dir for alembic script
1292367
@MiNeves00
fix: integration test action path for alembic.ini script
b353e6d
@MiNeves00
chore: changed the migration bash to python
890ba93
@MiNeves00
chore: changed the migration bash to python and corrected path
232ff13
@MiNeves00
fix: action
f968089
@MiNeves00
test: adding columns to check for integration tests for migrations
22ca8de
@MiNeves00
fix: alembic was not recognizing changes
c7dcfd5
@MiNeves00
fix: alembic
948c00a
@MiNeves00
chore: removed testing columns for logs
5e09f62
@MiNeves00
chore: added readme.md
174b1d7
@MiNeves00
feat: added extras to logs schema. alembic upgrades on tracker start …
3a0f51f 
…server if needed
@MiNeves00
chore: added .env.template; changed llmstudio alembic default name
6d1484a
@MiNeves00
chore: moved server alembic upgrade to utils; reverted poetry.lock of…
37672df 
… llmstudio lib
@MiNeves00
fix: alembic now raises error if bigquery migration is generated, if …
0475572 
…just upgraded it ignores - as its not supported by alembic.
@MiNeves00 MiNeves00 self-assigned this May 13, 2025
@MiNeves00 MiNeves00 marked this pull request as ready for review May 13, 2025 15:56
@MiNeves00 MiNeves00 requested a review from diogoncalves May 13, 2025 15:56
@MiNeves00 MiNeves00 removed the request for review from diogoncalves May 14, 2025 13:00
@MiNeves00 MiNeves00 merged commit e3ab87a into develop May 14, 2025
6 checks passed
@MiNeves00 MiNeves00 deleted the fix/alembic-ignore-bigquery branch May 14, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@MiNeves00 MiNeves00

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MiNeves00