Report user's call location in case of panic in into_*_value type of functions
#584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, when an
intoconversion fails, the error location reported points to the source code of Inkwell, e.g.This can be quite frustrating because, to determine where your program failed to perform the conversion, you either need to run it with
RUST_BACKTRACE=1and then examine the stack trace or use a debugger.Checklist
My code follows the code style of this project
I have added documentation and doc tests to any new functions or types
I have updated documentation and doc tests to any modified functions or types as applicable
I have added tests to cover my changes
All new and existing tests passed:
test result: ok. 328 passed; 0 failed; 18 ignored; 0 measured; 0 filtered out; finished in 5.23sI am basing my changes off master, instead of one of the llvm version branches (they're deprecated and no longer necessary)
I have ran cargo clippy and updated portions of code pertaining to my changes
I will keep my code reasonably up to date via rebasing over merging whenever possible (This helps avoid unnecessary merge commits)
I have read the Contributing Guide