fix: Correct UINT max value handling #784
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…HEX asserts as unsigned; applied the same unsigned logic across all integer-based comparisons.
burakutkuc
force-pushed
the
fix-assert-uint-overflow
branch
from
dd48114 to
ac52c41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to ThrowTheSwitch/CMock#509
In addition:
The following guard clause:
was replaced with:
if ((threshold == actual) && !(compare & UNITY_EQUAL_TO)) { failed = 1; }The goal was to align the behavior of the
UnityAssertGreaterOrLessOrEqualNumberfunction with its name.In the previous implementation, the function would return early without handling "greater or equal" or "less or equal" cases.
With this update, the function properly allows those comparisons when no failure condition is met.