-
Notifications
You must be signed in to change notification settings - Fork 4
Fix: imports nodes/tags only when needed #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Hehe, nice timing. I just finished my PoC :-D I got something working too, however - the partials are super annoying. Because used nodes & tags are not part of the node AST. Means for each partial used, we need to walk down the tree recursively. |
I'll try and see to review this weekend 👍🏻 fyi, here is my poc #146 and I stopped when I realized the partials part. |
Good news 🎉. I think I've solved the issue with partials. The demo website works great now. I noticed the changes in the PR #146 , using the extended type I think the direct import is safe, and it makes the implementation much more easier 😃 |
direct imports also fix the issue with barrel files (https://vitejs.dev/guide/performance#avoid-barrel-files). I'll try and see if I can review it tomorrow :-) |
fix: check partial nodes by name's annotations
8e077e0
to
7f2e8d5
Compare
disable caching in the transformer for now, need to implement invalidate cache mechanism.
Hey @TorstenDittmann , I've updated the test suite. |
c03ed3a
to
1ed9438
Compare
rm timeout to pass tests
This is my initial attempt to address the tree-shaking issue. I've focused on minimizing changes in the codebase while ensuring functional parity. However, some adjustments need to be made in the test suite, I have not touched anything in that folder yet.