Skip to content

Update submodule for Windows Aarch64 #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 30, 2025
Merged

Update submodule for Windows Aarch64 #31

merged 6 commits into from
Apr 30, 2025

Conversation

MarijnS95
Copy link
Member

Update the submodule to incorporate the fixes from pytorch/cpuinfo#283 and a (not-yet-merged) followup compilation fix from pytorch/cpuinfo#289.

@MarijnS95 MarijnS95 requested a review from maxded April 24, 2025 13:08
@MarijnS95 MarijnS95 force-pushed the aarch64 branch 2 times, most recently from 74c221b to 68f89f3 Compare April 24, 2025 13:24
@MarijnS95
Copy link
Member Author

It looks like cargo-cross doesn't provide a Docker image for running the tests on aarch64-pc-windows-msvc just yet:

cross-rs/cross#1509 (comment)
https://github.com/orgs/cross-rs/packages?tab=packages&q=aarch64

Pehaps we should only build-test it for now? Would like to unblock this :)

@MarijnS95
Copy link
Member Author

🤷 even after building & providing a docker image (which I'm sure it seemed to be using before), cargo cross still tries to run the tests natively:

https://github.com/Traverse-Research/cpuinfo-rs/actions/runs/14645278563/job/41097751171?pr=31

@MarijnS95 MarijnS95 force-pushed the aarch64 branch 6 times, most recently from 97cdb61 to ee8315c Compare April 25, 2025 08:48
@maxded maxded marked this pull request as ready for review April 30, 2025 12:14
@maxded maxded merged commit 22a4559 into main Apr 30, 2025
10 checks passed
@maxded maxded changed the title Update submodule and include tests for Windows Aarch64 Update submodule for Windows Aarch64 Apr 30, 2025
@MarijnS95 MarijnS95 deleted the aarch64 branch April 30, 2025 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants