Documentation Alerts bug fixing #2062
Conversation
github-actions
bot
added
the
pr: other
|
@yuri-kiss I'm going to want you to review this eventually but let's not merge this until I get the HTML issues fixed, please and thank you so much |
Brackets-Coder
changed the title
|
!format |
|
The formatting bot didn't find any formatting issues. It currently only checks the extensions folder. The author or a maintainer can run terminal command 'npm run format' manually to format all files. |
|
Why does Prettier remove the parentheses around the conditional part of ternary operators? it helps me read it better |
|
I guess this is acceptable enough now I fixed some nitpicks with how HTML was formatted |
|
if you feel strongly about prettier's choices then you can talk to the prettier people about that but ensuring consistency and not having to really talk about style is sort of why we use it. it was a much larger problem when we were doing eslint rules instead and people would see 1000+ errors if they just used the wrong size tab |
|
@CubesterYT Want to review this? |
|
or @yuri-kiss |
|
let's not merge this yet though I have some questions |
May I ask what those questions are? |
the one above for one |
As for the removed comment, it could go either way. To stay or not to stay? That is the question. It's up to you to answer. As for any other questions you might have, I might have an answer. |
Let's try this again.
This makes documentation alerts case-insensitive.
This is the easiest solution and is better than requiring all caps, as the latter breaks the alert's title and formatting.
Putting HTML into block alerts has extra padding due to empty auto-generated
<p>elements, planning on fixing whenever I can