Created the mondals extension. I want to add it to the turbowarp extension library. #2095
Conversation
github-actions
bot
added
the
pr: new extension
|
You'll want to do this in a separate branch so it's not in the master branch. Inside your fork of Turbowarp/extensions, you should have one branch per extension so it's easier to manage pull requests. When you're done that I might give it a review if I have time. |
I don't really understand you... I kind of did everything, entered what was needed, he wrote the code on a separate repository, in all the necessary folders. well, the code went a little wrong and the bot didn't pass, but I've changed it now. please add an extension, I tried very hard. |
I kindly ask you to restart the bot check and tell me exactly what I need to do. |
|
|
should I delete the folder and get the file from it, or what should I do?
|
| @@ -0,0 +1,72 @@ | |||
| // Name: Modals | |||
| // ID: htmlalert | |||
There was a problem hiding this comment.
this should contain a form of your name, and make sure the id's match
| @@ -0,0 +1,72 @@ | |||
| // Name: Modals | |||
| // ID: htmlalert | |||
| // Description: This extension adds modal dialog boxes. | |||
| getInfo() { | ||
| return { | ||
| id: "htmlalert", | ||
| name: "modals", |
| { | ||
| opcode: "alertb", | ||
| blockType: Scratch.BlockType.COMMAND, | ||
| text: "alert [textia]", |
There was a problem hiding this comment.
you need to use Scratch.translate
| getInfo() { | ||
| return { | ||
| id: "htmlalert", | ||
| name: "modals", |
| { | ||
| opcode: "Confirmb", | ||
| blockType: Scratch.BlockType.BOOLEAN, | ||
| text: "confirm [textic]", |
| { | ||
| opcode: "Promptb", | ||
| blockType: Scratch.BlockType.REPORTER, | ||
| text: "prompt [textip], default value: [classic]", |
| }; | ||
| } | ||
| alertb(args) { | ||
| alert([args.textia]); |
There was a problem hiding this comment.
this is a bad way to access the arguments and you don't cast any of them
https://github.com/scratch-craft-2/extensions/tree/master