Skip to content

Add Riemannian manifold HMC #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Add Riemannian manifold HMC #437

wants to merge 3 commits into from

Conversation

ErikQQY
Copy link
Collaborator

@ErikQQY ErikQQY commented May 4, 2025

Add the Riemannian manifold HMC from "Riemann manifold Langevin and Hamiltonian Monte Carlo methods" which is implemented in the research directory but has not been merged into the package. Supersede #432

Though this PR is relatively complete, there are still some things TODO:

  • Discuss the appropriate style for constructing a DenseRiemannianMetric, e.g., how should the metric tensor G be provided, etc.

  • Still need to add some docstrings and related documentation.

@ErikQQY ErikQQY changed the title git mv files Add Riemannian manifold HMC May 4, 2025
@ErikQQY
Copy link
Collaborator Author

ErikQQY commented May 4, 2025

Does files changed in PR also indicate renaming? Seems commit 1377742 does have the renaming history.

@yebai yebai mentioned this pull request May 5, 2025
@yebai
Copy link
Member

yebai commented May 5, 2025

@ErikQQY I renamed the files in #438 to make it easier for Git to track these changes. Can you create a new PR (or force push to this PR) with only the last commit 6d354da?

@ErikQQY
Copy link
Collaborator Author

ErikQQY commented May 5, 2025

@ErikQQY I renamed the files in #438 to make it easier for Git to track these changes. Can you create a new PR (or force push to this PR) with only the last commit 6d354da?

Sure! This PR get a bit messy, close in favor of #439

@ErikQQY ErikQQY closed this May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants