Replace indexed iteration by direct indexing #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haotian127
requested changes
Jul 30, 2022
There was a problem hiding this comment.
Thanks so much Daniel for pointing this out! It is actually a bug. T is supposed to be the QR factorization of a random matrix's Q factor instead of the first matrix entry. Could you help change this line to T = qr(randn(m,m)).Q instead? I have tested on my end and it works fine, since this part is only used to deal with corner cases.
|
I did the requested change. You can, if you want, modify the PR yourself. Do you want to add some test to make sure it works as expected? |
|
Thanks a lot for the fix! I will take over from here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came up in a nanosoldier run in JuliaLang/julia#46196. Independently from that PR, the iteration pattern used here is somewhat strange, and could be replaced by directly indexing the first element IIUC.