[PP-605] Add machine_nozzle_size to variants #20463
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the
machine_nozzle_sizeto the S-line variants that did not have them yet. This makes our jinja templates a lot cleaner and easier.This does not change any setting trees, as fdmprinter already defines the nozzle size as 0.4 as default. However, the nozzle size is strictly a property of the variant, so it's good to explicitly set it there.
The CC 0.4 variants already defined the
machine_nozzle_sizeas 0.4, so only the AA and BB cores are affected.