Skip to content

test: remove 2021 test projects except "HdrpStereoGraphicsTest-2021.3" #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 1, 2025

Conversation

sindharta
Copy link
Collaborator

No description provided.

@sindharta sindharta requested review from karasusan and H3idi-X April 28, 2025 08:00
Copy link
Collaborator

@H3idi-X H3idi-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it really OK to remove 2021.3? It looks we still support 2021.3 for Enterprise Customers.
https://unity.com/ja/blog/unity-2021-long-term-support-extended

@sindharta
Copy link
Collaborator Author

sindharta commented Apr 28, 2025

Yes. A couple of reasons:

  1. Enterprise Customers will receive support for 2021.3 until May 2025. That's only one month left
  2. Unity Toon Shader is experimental, and thus does not qualify as one of the supported packages (strictly speaking)
  3. I am in the middle of removing duplicate files after putting our samples as symbolic links into our test projects (PR). Removing 2021 projects will reduce the amount of effort to accomplish this.

@H3idi-X
Copy link
Collaborator

H3idi-X commented Apr 28, 2025

Let me clarify.

It looks Enterprise customres can get support until May 30, 2026, not May 30, 2025. because the following says they will get an additional year of support.

Unity 2022 LTS. No change. Fully supported until at least May 30, 2025. Enterprise customers will receive an additional year of support.

https://unity.com/blog/unity-2021-long-term-support-extended

Unity 2022 LTS変更はありません。少なくとも 2025 年 5 月 30 日までは完全なサポートが提供されます。Unity Enterprise、または Unity Industry をご利用のお客様には、さらに 1 年間サポートが追加されます。

https://unity.com/ja/blog/unity-2021-long-term-support-extended

@sindharta
Copy link
Collaborator Author

We are talking about Unity 2021, right ?
Not Unity 2022 ?

@H3idi-X
Copy link
Collaborator

H3idi-X commented Apr 28, 2025

Oh, sorry for my misunderstanding.

@karasusan
Copy link

We have the HDRP-DefaultVolumeProject-2020.3 in the repo.
Should we remove the folder in another PR?

@sindharta
Copy link
Collaborator Author

HDRP-DefaultVolumeProject-2020.3 is not a CI test project, so yes, if we decide to remove it, we can remove it in a different PR.

@sindharta sindharta merged commit 1acf7f3 into development/v1 May 1, 2025
32 checks passed
@sindharta sindharta deleted the remove-2021 branch May 1, 2025 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants