Skip to content

Fix test failure due to Num stringification #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

treyharris
Copy link

@treyharris treyharris commented Jan 19, 2020

Currently, you get a test failure like

===> Testing: Perl6-Math-Quaternion:auth<Bruce Gray>
[Perl6-Math-Quaternion] # Failed test '.norm'
[Perl6-Math-Quaternion] # at t/math_ops.t line 19
[Perl6-Math-Quaternion] # expected: '5.47722557505166'
[Perl6-Math-Quaternion] #      got: '5.477225575051661'
[Perl6-Math-Quaternion] # Looks like you failed 1 test of 38
===> Testing [FAIL]: Perl6-Math-Quaternion:auth<Bruce Gray>

Just change the is $q.norm, 5.47722557505166, '.norm' to use
is-aprox instead.

Just change the `is   $q.norm,   5.47722557505166,   '.norm'` to use
`is-aprox` instead.
@treyharris
Copy link
Author

If you’re receiving notifications via email, you’ll need to re-read this PR on the web at #9

Sorry for the initial truncated pull-req message; I had a sticky modifier key I didn’t realize and submitted the PR when I was trying to edit the message.

@AlexDaniel
Copy link

Same as #7, can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants