convert sprintf calls to snprintf #267
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partly addresses:
mac build provokes warnings
ValveSoftware#266
Many implementations have deprecated sprintf() in favor of snprintf(), including
macOS with latest Xcode and Windows if _CRT_SECURE_NO_WARNINGS is set.
This change converts all uses of sprintf() to snprintf(). In most cases this is
simply converting
sprintf(x, ...)
to
snprintf(x, sizeof(x), ...)
But there are a few more complicated constructions in fossilize_replay.cpp,
fossilize_db.cpp, and layer/instance.cpp.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partly addresses:
Many implementations have deprecated sprintf() in favor of snprintf(), including macOS with latest Xcode and Windows if _CRT_SECURE_NO_WARNINGS is set.
This change converts all uses of sprintf() to snprintf(). In most cases this is simply converting
sprintf(x, ...)
to
snprintf(x, sizeof(x), ...)
But there are a few more complicated constructions in fossilize_replay.cpp, fossilize_db.cpp, and layer/instance.cpp.